src/plugin/PluginTabBase.cpp - Issue 11043057: First run page triggering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginTabBase.cpp

Issue 11043057: First run page triggering (Closed)

Left Patch Set: Injecting an object for localization Created July 20, 2013, 10:41 p.m.

Right Patch Set: Minor refactoring. Renaming and a small cleanup. Created July 26, 2013, 12:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #include "PluginStdAfx.h"	1 #include "PluginStdAfx.h"

2	2

3 #include "PluginClient.h"	3 #include "PluginClient.h"

4 #include "PluginSettings.h"	4 #include "PluginSettings.h"

5 #ifdef SUPPORT_CONFIG	5 #ifdef SUPPORT_CONFIG

6 #include "PluginConfig.h"	6 #include "PluginConfig.h"

7 #endif	7 #endif

8 #include "PluginTab.h"	8 #include "PluginTab.h"

9 #include "PluginDomTraverser.h"	9 #include "PluginDomTraverser.h"

10 #include "PluginClass.h"	10 #include "PluginClass.h"

(...skipping 117 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
128 {	128 {

129 if (url != documentUrl)	129 if (url != documentUrl)

130 {	130 {

131 SetDocumentUrl(url);	131 SetDocumentUrl(url);

132 }	132 }

133	133

134 CString log;	134 CString log;

135 log.Format(L"Current URL: %s, settings URL: %s", url, UserSettingsFileUrl(). c_str());	135 log.Format(L"Current URL: %s, settings URL: %s", url, UserSettingsFileUrl(). c_str());

136 DEBUG_GENERAL(log);	136 DEBUG_GENERAL(log);

137 if (0 == url.CompareNoCase(CString(UserSettingsFileUrl().c_str())) \|\|	137 if (0 == url.CompareNoCase(CString(UserSettingsFileUrl().c_str())) \|\|

138 0 == url.CompareNoCase(CString(UserSettingsFirstRunPageUrl().c_str())) )	138 0 == url.CompareNoCase(CString(FirstRunPageFileUrl().c_str())) )

139 {	139 {

140 CComPtr<IDispatch> pDocDispatch;	140 CComPtr<IDispatch> pDocDispatch;

141 browser->get_Document(&pDocDispatch);	141 browser->get_Document(&pDocDispatch);

142 CComQIPtr<IHTMLDocument2> pDoc2 = pDocDispatch;	142 CComQIPtr<IHTMLDocument2> pDoc2 = pDocDispatch;

143 if (pDoc2)	143 if (pDoc2)

144 {	144 {

145 CComPtr<IHTMLWindow2> pWnd2;	145 CComPtr<IHTMLWindow2> pWnd2;

146 pDoc2->get_parentWindow(&pWnd2);	146 pDoc2->get_parentWindow(&pWnd2);

147 if (pWnd2)	147 if (pWnd2)

148 {	148 {

(...skipping 210 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
359	359

360 // Non-hanging sleep	360 // Non-hanging sleep

361 Sleep(50);	361 Sleep(50);

362 }	362 }

363	363

364 tabLoopIteration++;	364 tabLoopIteration++;

365 }	365 }

366	366

367 return 0;	367 return 0;

368 }	368 }

LEFT	RIGHT