First run page triggering

src/engine/main.cpp

 #include <AdblockPlus.h>
 #include <functional>
 #include <vector>
 #include <Windows.h>
 
 #include "../shared/AutoHandle.h"
 #include "../shared/Communication.h"
 #include "../shared/Dictionary.h"
 #include "../shared/Utils.h"
 #include "../shared/Version.h"
@@ skipping 23 matching lines @@
     {
       AdblockPlus::SubscriptionPtr subscription = subscriptions[i];
       response << subscription->GetProperty("url")->AsString()
                << subscription->GetProperty("title")->AsString()
                << subscription->GetProperty("specialization")->AsString()
                << subscription->IsListed();
     }
   }
   
   CriticalSection firstRunLock;
-  bool firstRunActionTaken = false;

[Felix Dahlke, 2013/07/25 14:54:37]

"firstRunActionTaken" sounds wrong to my ears, I think "firstRunActionExecuted"
is better. Not a native speaker though, so CMIIW.

+  bool firstRunActionExecuted = false;
 
   Communication::OutputBuffer HandleRequest(Communication::InputBuffer& request)
   {
     Communication::OutputBuffer response;
 
     Communication::ProcType procedure;
     request >> procedure;
     switch (procedure)
     {
       case Communication::PROC_MATCHES:
@@ skipping 156 matching lines @@
         else if (valuePtr->IsNumber())
         {
           response << valuePtr->AsInt();
         }
         else if (valuePtr->IsString())
         {
           response << valuePtr->AsString();
         }
         break;
       }
       case Communication::PROC_IS_FIRST_RUN_ACTION_NEEDED:

[Felix Dahlke, 2013/07/25 14:54:37]

How about PROC_IS_FIRST_RUN? The function invoking this is called IsFirstRun()
after all.

[Oleksandr, 2013/07/26 12:07:01]

I would say the PROC_IS_FIRST_RUN would be confusing, since one might think it
is just checking for IsFirstRun. That is not the case, so I wanted to be more
explicit here.

On 2013/07/25 14:54:37, Felix H. Dahlke wrote:

[Felix Dahlke, 2013/08/02 10:52:24]

Fair enough I guess. Might want to rename IsFirstRun() though.

       {
         CriticalSection::Lock lock(firstRunLock);
-        if (!firstRunActionTaken && filterEngine->IsFirstRun())
+        if (!firstRunActionExecuted && filterEngine->IsFirstRun())
         {
           response << true;
-          firstRunActionTaken = true;
+          firstRunActionExecuted = true;
         }
         else
         {
           response << false;
         }
         break;
       }
 
     }
     return response;
@@ skipping 99 matching lines @@
     }
     catch (std::runtime_error e)
     {
       DebugException(e);
       return 1;
     }
   }
 
   return 0;
 }