First run page triggering

src/plugin/PluginClass.cpp

Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -998,9 +998,57 @@
   HDC hdc = GetWindowDC(m_hStatusBarWnd);
   SendMessage(m_hStatusBarWnd, WM_PAINT, (WPARAM)hdc, 0);
   ReleaseDC(m_hStatusBarWnd, hdc);
+
+  if (CPluginClient::GetInstance()->GetIsFirstRun())

[Wladimir Palant, 2013/07/11 11:58:10]

Is CreateStatusBarPane() really the best place for this code? For example, what
about IE6, don't we want to show the first-run page there? Also, won't this code
run twice on some occasions?

From what I understand, this belongs into CPluginClass::InitObject(). Also, we
need to ensure that this code only runs once, no matter how many processes are
created. That's best to be done in the engine - rename the call into something
like PROC_FIRST_RUN_ACTIONS_NEEDED and have it return true only the first time
it is called (critical section required here).

+  {   
+    CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
+  }
+
   return true;
 }
 
+void CPluginClass::FirstRunThread()
+{
+  // IE may still be not ready to navigate. Try until it is.
+  VARIANT_BOOL isBusy = VARIANT_FALSE;
+  while (GetAsyncBrowser()->get_Busy(&isBusy) == S_OK && isBusy != VARIANT_FALSE)
+  {
+    Sleep(100);
+  }
+  VARIANT vFlags;
+  vFlags.vt = VT_I4;
+  vFlags.intVal = navOpenInNewTab;
+
+  READYSTATE readyState;
+  HRESULT hr;
+  while ((hr = GetAsyncBrowser()->get_ReadyState(&readyState) == S_OK) && (readyState <= READYSTATE_LOADED))

[Wladimir Palant, 2013/07/11 11:58:10]

We are opening in a new tab, why do we care about the ready state of the current
page?

+  {
+    Sleep(100);
+  }
+  CComBSTR bTest = CComBSTR(UserSettingsFirstRunPageUrl().c_str());
+  
+  //Try 10 times, or until successful
+  int numberOfAttempts = 0;
+  while ((hr != S_OK) && (numberOfAttempts < 10))
+  {
+    hr = GetAsyncBrowser()->Navigate(bTest, &vFlags, NULL, NULL, NULL);
+    if (FAILED(hr))
+    {
+      vFlags.intVal = navOpenInNewWindow;
+
+      hr = GetAsyncBrowser()->Navigate(bTest, &vFlags, NULL, NULL, NULL);
+      if (FAILED(hr))
+      {
+        DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_NAVIGATION, PLUGIN_ERROR_NAVIGATION_SETTINGS, "Navigation::Failed")

[Wladimir Palant, 2013/07/11 11:58:10]

This should probably be PLUGIN_ERROR_NAVIGATION_WELCOME rather than
PLUGIN_ERROR_NAVIGATION_SETTINGS. Either way, do we really need all these debug
messages? Wouldn't one be sufficient, after 10 failed attempts?

+      }
+    }
+    Sleep(100);
+  }

[Wladimir Palant, 2013/07/11 11:58:10]

Does it really have to be that complicated? No other occasions where we open a
new tab take special precautions. If they are necessary then we probably should
create a helper function to open a tab and use it consistently. If not - well...

[Oleksandr, 2013/07/20 20:22:30]

This turned out to be unnecessary after all. I've been having issues with
Navigate failing, but it turned out for a completely different reason. All works
fine like this.
On 2013/07/11 11:58:10, Wladimir Palant wrote:

+  if (FAILED(hr))
+  {
+    DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_NAVIGATION, PLUGIN_ERROR_NAVIGATION_WELCOME, "Navigation::Welcome page failed")
+  }
+}
 void CPluginClass::CloseTheme()
 {
   if (m_hTheme)
@@ -1731,88 +1779,6 @@
 #endif
     }
     break;
-
-
-    // First run page 
-    case WM_LAUNCH_INFO:

[Wladimir Palant, 2013/07/11 11:58:10]

You probably want to remove the definition of that message as well.

-    {
-      // Set the status bar visible, if it isn't
-      // Otherwise the user won't see the icon the first time
-
-      if (wParam == 1)
-      {
-        // Redirect to welcome page
-        VARIANT_BOOL isVisible;
-        CComQIPtr<IWebBrowser2> browser = GetAsyncBrowser();
-        if (browser)
-        {
-          HRESULT hr = S_OK;
-
-          hr = browser->get_StatusBar(&isVisible);
-          if (SUCCEEDED(hr))
-          {
-            if (!isVisible)
-            {
-              Dictionary* dictionary = Dictionary::GetInstance();
-
-              LRESULT res = MessageBox(NULL,
-                  dictionary->Lookup("status-bar", "question").c_str(),
-                  dictionary->Lookup("status-bar", "title").c_str(),
-                  MB_YESNO);
-              if (res == IDYES)
-              {
-                hr = browser->put_StatusBar(TRUE);
-                if (FAILED(hr))
-                {
-                  DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_UI, PLUGIN_ERROR_UI_PUT_STATUSBAR, "Class::Enable statusbar");
-                }
-              }
-            }
-          }
-          else
-          {
-            DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_UI, PLUGIN_ERROR_UI_GET_STATUSBAR, "Class::Get statusbar state");
-          }
-
-          CPluginSettings* settings = CPluginSettings::GetInstance();
-
-          //TODO: Navigate to first run page here
-/*        hr = browser->Navigate(CComBSTR("FIRST_RUN_PAGE_URL"), NULL, NULL, NULL, NULL);
-          if (FAILED(hr))
-          {
-            DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_NAVIGATION, PLUGIN_ERROR_NAVIGATION_WELCOME, "Navigation::Welcome page failed")
-          }
-          */
-        }
-      }
-      else
-      {
-        // Redirect to info page
-        CComQIPtr<IWebBrowser2> browser = GetAsyncBrowser();
-        if (browser)
-        {
-          VARIANT vFlags;
-          vFlags.vt = VT_I4;
-          vFlags.intVal = navOpenInNewTab;
-
-          // TODO: Navigate to info page here or remove this clause
-/*          HRESULT hr = browser->Navigate(CComBSTR(INFO_PAGE_URL), &vFlags, NULL, NULL, NULL);
-          if (FAILED(hr))
-          {
-            vFlags.intVal = navOpenInNewWindow;
-
-            hr = browser->Navigate(CComBSTR(httpRequest.GetUrl()), &vFlags, NULL, NULL, NULL);
-            if (FAILED(hr))
-            {
-              DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_NAVIGATION, PLUGIN_ERROR_NAVIGATION_INFO, "Navigation::Info page failed")
-            }
-          }
-          */
-        }
-      }
-    }
-    break;
-
   case WM_DESTROY:
     break;
   case SC_CLOSE: