First run page triggering

src/engine/main.cpp

Index: src/engine/main.cpp
===================================================================
--- a/src/engine/main.cpp
+++ b/src/engine/main.cpp
@@ -8,6 +8,7 @@
 #include "../shared/Dictionary.h"
 #include "../shared/Utils.h"
 #include "../shared/Version.h"
+#include "../shared/CriticalSection.h"
 #include "Debug.h"
 #include "Updater.h"
 
@@ -38,6 +39,9 @@
                << subscription->IsListed();
     }
   }
+  
+  CriticalSection firstRunLock;
+  bool firstRunActionTaken = false;

[Felix Dahlke, 2013/07/25 14:54:37]

"firstRunActionTaken" sounds wrong to my ears, I think "firstRunActionExecuted"
is better. Not a native speaker though, so CMIIW.

 
   Communication::OutputBuffer HandleRequest(Communication::InputBuffer& request)
   {
@@ -214,6 +218,20 @@
         }
         break;
       }
+      case Communication::PROC_IS_FIRST_RUN_ACTION_NEEDED:

[Felix Dahlke, 2013/07/25 14:54:37]

How about PROC_IS_FIRST_RUN? The function invoking this is called IsFirstRun()
after all.

[Oleksandr, 2013/07/26 12:07:01]

I would say the PROC_IS_FIRST_RUN would be confusing, since one might think it
is just checking for IsFirstRun. That is not the case, so I wanted to be more
explicit here.

On 2013/07/25 14:54:37, Felix H. Dahlke wrote:

[Felix Dahlke, 2013/08/02 10:52:24]

Fair enough I guess. Might want to rename IsFirstRun() though.

+      {
+        CriticalSection::Lock lock(firstRunLock);
+        if (!firstRunActionTaken && filterEngine->IsFirstRun())
+        {
+          response << true;
+          firstRunActionTaken = true;
+        }
+        else
+        {
+          response << false;
+        }
+        break;
+      }
 
     }
     return response;