Be more selective for the sharing fallback

chrome/content/ui/firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 195 matching lines @@
     networks.forEach(function(network)
     {
       var link = E("share-" + network);
       link.addEventListener("click", onSocialLinkClick, false);
     });
   }
 
   function onSocialLinkClick(event)
   {
     // Don't open the share page if the sharing script would be blocked
-    var filter = defaultMatcher.matchesAny(event.target.getAttribute("_script"), "SCRIPT", "adblockplus.org", true);

[Thomas Greiner, 2013/07/08 13:46:47]

_script is not a standard attribute for anchor tags. Please use data-script
instead.

+    var filter = defaultMatcher.matchesAny(event.target.getAttribute("data-script"), "SCRIPT", "adblockplus.org", true);
     if (!(filter instanceof BlockingFilter))
     {
       event.preventDefault();
       openSharePopup(Utils.getDocLink(event.target.id));
     }
   }
 
   function setLinks(id)
   {
     var element = E(id);
@@ skipping 22 matching lines @@
       UI.openFiltersDialog();
     else
     {
       backgroundPage.openOptions();
     }
   }
 
   function updateToggleButton(feature, isEnabled)
   {
     var button = E("toggle-" + feature);
-    if (isEnabled && button.classList.contains("off"))
+    if (isEnabled)
       button.classList.remove("off");
-    else if (!isEnabled && !button.classList.contains("off"))
+    else
       button.classList.add("off");
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();