Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/info.js

Issue 11137033: Update info module to return better application/platform information (Closed)
Patch Set: Created July 19, 2013, 3:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .hgsubstate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/info.js
===================================================================
--- a/lib/info.js
+++ b/lib/info.js
@@ -14,15 +14,25 @@
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
exports.__defineGetter__("addonID", function()
{
return chrome.i18n.getMessage("@@extension_id");
});
-exports.addonVersion = "2.1"; // Hardcoded for now
-exports.__defineGetter__("addonName", function()
-{
- return chrome.i18n.getMessage("name");
-});
+exports.addonName = "adblockpluschrome";
+exports.addonVersion = "2.3"; // Hardcoded for now
exports.addonRoot = "";
-exports.application = "chrome";
+exports.application = "opr" in window ? "opera" : "chrome";
+exports.platform = "chromium";
+
+let match = /\bChrome\/(\S+)/.exec(navigator.userAgent);
+if (match)
+ exports.platformVersion = match[1];
+else
+ exports.platformVersion = "0";
+
+match = (exports.application == "opera" ? /\bOPR\/(\S+)/.exec(navigator.userAgent) : null);
+if (match)
+ exports.applicationVersion = match[1];
+else
+ exports.applicationVersion = exports.platformVersion;
« no previous file with comments | « .hgsubstate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld