Show notifications on startup (Chrome)

notification.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 58 matching lines @@
     notification.onClicked();
 
   var texts = Notification.getLocalizedTexts(notification);
   var titleElement = document.getElementById("title");
   titleElement.textContent = texts.title;
 
   var docLinks = getDocLinks(notification);
   var messageElement = document.getElementById("message");
   insertMessage(messageElement, texts.message, docLinks);
 
-  var linkElements = messageElement.getElementsByTagName("a");
-  for (var i = 0; i < linkElements.length; i++)
+  messageElement.addEventListener("click", function(event)
   {
-    var linkElement = linkElements[i];
-    linkElement.addEventListener("click", function(event)
-    {
-      event.preventDefault();
-      event.stopPropagation();
-      chrome.tabs.create({url: linkElement.href});
-    });
-  }

[Wladimir Palant, 2013/07/22 14:18:36]

So this loop is only there to attach event listeners to links? This is
pointless, one event listener at the top level will do:

messageElement.addEventListener("click", function(event)
{
  var link = event.target;
  while (link && link != messageElement && link.localName != "a")
    link = link.parentNode;
  if (link)
  {
    event.preventDefault();
    event.stopPropagation();
    chrome.tabs.create({url: link.href});
  }
}, false);

[Felix Dahlke, 2013/07/22 15:10:22]

Yes, that would also work. Note that we have pretty much the same code in
Firefox though, wouldn't we want to change it there as well then?

[Wladimir Palant, 2013/07/23 07:25:04]

Sure, it should be changed there as well.

[Felix Dahlke, 2013/07/23 10:38:08]

Done.

+    var link = event.target;
+    while (link && link !== messageElement && link.localName !== "a")
+      link = link.parentNode;
+    if (!link)
+      return;
+    event.preventDefault();
+    event.stopPropagation();
+    chrome.tabs.create({url: link.href});
+  });
 
   var notificationElement = document.getElementById("notification");
   notificationElement.className = notification.severity;
   notificationElement.style.display = "block";
 });