Show notifications on startup (Chrome)

background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 547 matching lines @@
         interval = 10000;
       }
       iconAnimationTimer = setTimeout(animationStep, interval);
     }
     animationStep();
   });
 }
 
 function prepareNotificationIconAndPopup()
 {
-  function refreshAll(tabs)
-  {
-    tabs.forEach(refreshIconAndContextMenu);
-  }
-
   activeNotification.onClicked = function()
   {
+    var tab = animatedIconTab;
     stopIconAnimation();
     activeNotification = null;
-    chrome.tabs.query(null, refreshAll);
+    refreshIconAndContextMenu(tab);
   };
 
-  chrome.tabs.query({active: true, currentWindow: true}, refreshAll);

[Felix Dahlke, 2013/07/23 10:38:08]

I just noticed that I still use currentWindow here, which is apparently not
supported in Chrome 18. Will fix that in a bit.

[Felix Dahlke, 2013/07/23 11:24:57]

Done. Note that this was incorrect anyway, the current window is not necessarily
the currently focused window.

+  chrome.windows.getLastFocused({populate: true}, function(window)
+  {
+    chrome.tabs.query({active: true, windowId: window.id}, function(tabs)
+    {
+      tabs.forEach(refreshIconAndContextMenu);
+    });
+  });
 }
 
 function showNotification(notification)
 {
   activeNotification = notification;
 
   if (activeNotification.severity === "critical")
   {
     var notification = webkitNotifications.createHTMLNotification("notification.html");
     notification.show();
@@ skipping 137 matching lines @@
 {
   chrome.tabs.sendRequest(tabId, {reqtype: "clickhide-deactivate"})
   if(changeInfo.status == "loading")
     refreshIconAndContextMenu(tab);
 });
 
 // Refresh icon when switching tabs or windows
 chrome.tabs.onActivated.addListener(function(activeInfo)
 {
   refreshIconAndContextMenu(animatedIconTab);
-  chrome.tabs.get(activeInfo.tabId, function(tab)
-  {
-    refreshIconAndContextMenu(tab);
-  });
+  chrome.tabs.get(activeInfo.tabId, refreshIconAndContextMenu);
 });
 chrome.windows.onFocusChanged.addListener(function(windowId)
 {
   refreshIconAndContextMenu(animatedIconTab);
   chrome.tabs.query({active: true, windowId: windowId}, function(tabs)
   {
-    refreshIconAndContextMenu(tabs[0]);
+    tabs.forEach(refreshIconAndContextMenu);
   });
 });
 
 setTimeout(function()
 {
   var notificationToShow = Notification.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);