Show notifications on startup (Chrome)

notification.js

+/*
+ * This file is part of Adblock Plus <http://adblockplus.org/>,
+ * Copyright (C) 2006-2013 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+var backgroundPage = chrome.extension.getBackgroundPage();
+var require = backgroundPage.require;
+
+var Utils = require("utils").Utils;
+var Notification = require("notification").Notification;
+
+function getDocLinks(notification)
+{
+  if (!notification.links)
+    return [];
+
+  var docLinks = [];
+  notification.links.forEach(function(link)
+  {
+    docLinks.push(Utils.getDocLink(link));
+  });
+  return docLinks;
+}
+
+function insertMessage(element, text, links)
+{
+  var match = /^(.*?)<(a|strong)>(.*?)<\/\2>(.*)$/.exec(text);
+  if (!match)
+  {
+    element.appendChild(document.createTextNode(text));
+    return;
+  }
+
+  var before = match[1];
+  var tagName = match[2];
+  var value = match[3];
+  var after = match[4];
+
+  insertMessage(element, before, links);
+
+  var newElement = document.createElement(tagName);
+  if (tagName === "a" && links && links.length)
+    newElement.href = links.shift();
+  insertMessage(newElement, value, links);
+  element.appendChild(newElement);
+
+  insertMessage(element, after, links);
+}
+
 window.addEventListener("load", function()
 {
-  var backgroundPage = chrome.extension.getBackgroundPage();
   var notification = backgroundPage.activeNotification;
   if (!notification)
     return;
 
   if (notification.onClicked)
     notification.onClicked();
 
-  var texts = backgroundPage.getLocalizedTexts(notification);

[Wladimir Palant, 2013/07/21 11:15:30]

Call Notification and Utils directly here (via require) rather than asking the
background page to do it?

[Felix Dahlke, 2013/07/22 12:30:15]

Done. Not sure why I didn't do it in fact.

+  var texts = Notification.getLocalizedTexts(notification);
   var titleElement = document.getElementById("title");
-  titleElement.innerHTML = texts.title;

[Wladimir Palant, 2013/07/21 11:15:30]

textContent please, not innerHTML.

[Felix Dahlke, 2013/07/22 12:30:15]

Done.

+  titleElement.textContent = texts.title;
+
+  var docLinks = getDocLinks(notification);
   var messageElement = document.getElementById("message");
-  messageElement.innerHTML = texts.message;

[Wladimir Palant, 2013/07/21 11:15:30]

Please use the same code as in Firefox here, not innerHTML.

[Felix Dahlke, 2013/07/21 12:19:53]

Hehe, I thought I'd try :D This should be safe in Chrome, but I can see how
you'd rather not rely on that.

[Felix Dahlke, 2013/07/22 12:30:15]

Done. I think it's less than great that this code is duplicated in Chrome, but I
don't see a way of using the same code in a manner that makes a lot of sense. I
mean, we could have some function with callbacks for creating/attaching the
objects in the Notification module, but I think it's not ideal. Got a better
idea?

+  insertMessage(messageElement, texts.message, docLinks);
 
-  var docLinks = backgroundPage.getDocLinks(notification);
-  var linkElements = messageElement.getElementsByTagName("a");
-  for (var i = 0; i < linkElements.length; i++)
+  messageElement.addEventListener("click", function(event)
   {
-    var linkElement = linkElements[i];
-    if (docLinks && docLinks.length)
-      linkElement.href = docLinks.shift();
-    linkElement.addEventListener("click", function(event)
-    {
-      event.preventDefault();
-      event.stopPropagation();
-      chrome.tabs.create({url: linkElement.href});
-    });
-  }
+    var link = event.target;
+    while (link && link !== messageElement && link.localName !== "a")
+      link = link.parentNode;
+    if (!link)
+      return;
+    event.preventDefault();
+    event.stopPropagation();
+    chrome.tabs.create({url: link.href});
+  });
 
   var notificationElement = document.getElementById("notification");
   notificationElement.className = notification.severity;
   notificationElement.style.display = "block";
 });