Show notifications on startup

lib/ui.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 413 matching lines @@
     }.bind(this));
     FilterNotifier.addListener(function(action)
     {
       if (/^(filter|subscription)\.(added|removed|disabled|updated)$/.test(action) || action == "load")
         this.updateState();
     }.bind(this));
 
     notificationTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
     notificationTimer.initWithCallback(this._showNextNotification.bind(this),
                                        3 * 60 * 1000, Ci.nsITimer.TYPE_ONE_SHOT);
     onShutdown.add(function() notificationTimer.cancel());

[Wladimir Palant, 2013/07/20 07:18:07]

We need to verify that this doesn't cause an error if the timer already fired.

[Felix Dahlke, 2013/07/20 23:00:51]

I haven't see us do that in other places, so it seems to be fine, does it? The
docs don't say anything about whether cancelling an already fired one shot timer
should be a problem, nor does it seem to be possible to figure out if a timer
has already been fired. So I suppose I'd have to manually remove the shutdown
handler then.

Just tested this by closing Firefox after the notification has been shown. No
errors or anything, so it seems to be fine.

[Wladimir Palant, 2013/07/21 11:30:17]

I other places we are using repeating timers, not one-time timers.
The way to test this would be to disable Adblock Plus - it's extension shutdown,
not the browser shutdown ;)

Either way, I verified that nsITimer.cancel() doesn't throw errors even when
called multiple times.

   },
 
   /**
    * Will be set to true after the check whether first-run actions should run
    * has been performed.
    * @type Boolean
    */
   firstRunDone: false,
 
   /**
@@ skipping 1539 matching lines @@
 
     let links = window.document.querySelectorAll("#abp-notification-message a");
     for each (let link in links)
     {
       let url = link.href;
       let ui = this;
       link.onclick = function(event)
       {
         event.preventDefault();
         event.stopPropagation();
-        if (!/^https?:\/\//.test(url))
-        {
-          Cu.reportError("Illegal link scheme in URL: " + url);
-          return;
-        }

[Wladimir Palant, 2013/07/20 07:18:07]

The URL no longer comes from server so we can just assume that it is safe - this
code isn't required now.

         ui.loadInBrowser(url, window);
       };
     }
 
     let panel = window.document.getElementById("abp-notification");
     panel.openPopup(button, "bottomcenter topcenter", 0, 0, false, false, null);
   }
 };
 UI.onPopupShowing = UI.onPopupShowing.bind(UI);
 UI.onKeyPress = UI.onKeyPress.bind(UI);
@@ skipping 22 matching lines @@
   ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
   ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
 ];
 
 onShutdown.add(function()
 {
   for (let window in UI.applicationWindows)
     if (UI.isBottombarOpen(window))
       UI.toggleBottombar(window);
 });