Fix the crash. IInternetBindInfo BINDSTRING_XDR_ORIGIN bug workaround.

src/plugin/PluginWbPassThrough.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginWbPassThrough.h"
 #include "PluginClient.h"
 #include "PluginClientFactory.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
 #include "PluginSettings.h"
 #include "PluginClass.h"
@@ skipping 119 matching lines @@
   DEBUG_GENERAL(src);
   CPluginClient::UnescapeUrl(src);
   m_url = szUrl;
 
   CString boundDomain;
   CString mimeType;
   if (pOIBindInfo)
   {
     ULONG resLen = 0;
     LPOLESTR mime = 0;
     HRESULT hr = pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, &mime, 1, &resLen);

[Felix Dahlke, 2013/08/08 14:13:55]

Just noticed that hr is unused here, we shouldn't set it here then and declare
it on first use.

[Felix Dahlke, 2013/08/09 07:12:33]

You haven't addressed this comment. 

     if (mime && resLen > 0)
     {
       mimeType.SetString(mime);
     }
+    LPOLESTR bindToObject = 0;
+    hr = pOIBindInfo->GetBindString(BINDSTRING_FLAG_BIND_TO_OBJECT, &bindToObject, 1, &resLen);
     LPOLESTR domainRetrieved = 0;
-    hr = pOIBindInfo->GetBindString(BINDSTRING_XDR_ORIGIN, &domainRetrieved, 1, &resLen);
+    if (resLen == 0 || wcscmp(bindToObject, L"FALSE") == 0)
+    {   
+      hr = pOIBindInfo->GetBindString(BINDSTRING_XDR_ORIGIN, &domainRetrieved, 1, &resLen);
+    }
     if ((hr == S_OK) && domainRetrieved && (resLen > 0))

[Felix Dahlke, 2013/08/05 14:28:05]

Shouldn't this be moved into the if as well? What happens if resLen is not null
but bindToObject was not FALSE? We'll do something with domainRetrieved which is
0.

[Oleksandr, 2013/08/08 14:03:20]

I might be missing something but we will not do anything with the
domainRetrieved, because it's 0 in this if. So the end result would be an empty
string boundDomain.
On 2013/08/05 14:28:05, Felix H. Dahlke wrote:

[Felix Dahlke, 2013/08/08 14:13:55]

Right, there's a check for domainRetrieved there, so it'll work as intended.

I still think it's a bit confusing this way, we should move this code into the
if above, it logically runs only under that condition.

[Oleksandr, 2013/08/08 14:22:21]

Agreed. 
On 2013/08/08 14:13:55, Felix H. Dahlke wrote:

     {
       boundDomain.SetString(domainRetrieved);
       // Remove protocol
       int pos = boundDomain.Find(L"://");
       if (pos > 0)
       {
         boundDomain = boundDomain.Mid(pos + 3);
       }
       // Remove port
       pos = boundDomain.Find(L":");
@@ skipping 204 matching lines @@
   CComPtr<IHttpNegotiate> spHttpNegotiate;
   QueryServiceFromClient(&spHttpNegotiate);
 
   return spHttpNegotiate ? spHttpNegotiate->OnResponse(dwResponseCode, szResponseHeaders, szRequestHeaders, pszAdditionalRequestHeaders) : S_OK;
 }
 
 STDMETHODIMP WBPassthruSink::ReportProgress(ULONG ulStatusCode, LPCWSTR szStatusText)
 {
   return m_spInternetProtocolSink ? m_spInternetProtocolSink->ReportProgress(ulStatusCode, szStatusText) : S_OK;
 }