installer/bootstrap-theme.wxl - Issue 11258006: Bootstrapper

Side by Side Diff: installer/bootstrap-theme.wxl

Issue 11258006: Bootstrapper (Closed)

Patch Set: Created July 25, 2013, 9:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <WixLocalization Culture="en-us" Language="1033" xmlns="http://schemas.microsoft .com/wix/2006/localization">

	3 <String Id="BundleName">Adblock Plus for IE</String>

	4 <String Id="Caption">[WixBundleName] Setup</String>

	5 <String Id="Title">[WixBundleName]</String>

	6 <String Id="ConfirmCancelMessage">Are you sure you want to cancel?</String>
	Wladimir Palant 2013/08/01 10:30:33 I think this is the more common way to phrase it: I think this is the more common way to phrase it: Are you sure you wish to abort installation? Eric 2013/08/01 18:58:37 The problem is that there's only one cancellation The problem is that there's only one cancellation dialog no matter what you're cancelling: (1) initial installation dialog or (2) repair/uninstall dialog. It's a defect, IMO, that these use the same string. But fixing it means rewriting the whole UI code. I left it generic so that it basically fits both situations.
	7 <String Id="HelpHeader">Setup Help</String>

	8 <String Id="HelpText">/install \| /repair \| /uninstall \| /layout [directory] - installs, repairs, uninstalls or

	9 creates a complete local copy of the bundle in directory. Install is the defa ult.

	10

	11 /passive \| /quiet - displays minimal UI with no prompts or displays no UI and

	12 no prompts. By default UI and all prompts are displayed.

	13

	14 /norestart - suppress any attempts to restart. By default UI will prompt befor e restart.

	15 /log log.txt - logs to a specific file. By default a log file is created in %TEM P%.</String>

	16 <String Id="HelpCloseButton">&Close</String>

	17

	18 <!-- Install dialog -->

	19 <String Id="InstallHeader">Setup Start</String>

	20 <String Id="InstallWelcome">This setup program installs Adblock Plus for IE in to your "Program Files" folder in directory "Adblock Plus for IE".</String>
	Felix Dahlke 2013/08/01 09:51:21 I think this sounds a bit awkward, can't we have s I think this sounds a bit awkward, can't we have something like: This setup program installs Adblock Plus for IE to "%PROGRAM_FILES%/Adblock Plus for IE" Or maybe just: This setup program installs Adblock Plus for IE to your "Program Files" directory. Wladimir Palant 2013/08/01 10:30:33 I don't think we should refer to environment varia Show quoted text On 2013/08/01 09:51:21, Felix H. Dahlke wrote: > I think this sounds a bit awkward, can't we have something like: This setup > program installs Adblock Plus for IE to "%PROGRAM_FILES%/Adblock Plus for IE" Or > maybe just: This setup program installs Adblock Plus for IE to your "Program > Files" directory. I don't think we should refer to environment variables here, our users won't know about them. So I would go with your second suggestion: This setup program installs [WixBundleName] to your "Program Files" directory. Note that we should use WixBundleName consistently. Felix Dahlke 2013/08/01 10:52:43 Well, I meant to actually show the full path to th Show quoted text On 2013/08/01 10:30:33, Wladimir Palant wrote: > On 2013/08/01 09:51:21, Felix H. Dahlke wrote: > > I think this sounds a bit awkward, can't we have something like: This setup > > program installs Adblock Plus for IE to "%PROGRAM_FILES%/Adblock Plus for IE" > Or > > maybe just: This setup program installs Adblock Plus for IE to your "Program > > Files" directory. > > I don't think we should refer to environment variables here, our users won't > know about them. So I would go with your second suggestion: > > This setup program installs [WixBundleName] to your "Program Files" directory. > > Note that we should use WixBundleName consistently. Well, I meant to actually show the full path to the target folder, %PROGRAM_FILES% isn't even a variable. But yeah, might be better to go with the simpler second variant. Eric 2013/08/01 18:58:37 The biggest problem with this message is that ther Show quoted text On 2013/08/01 09:51:21, Felix H. Dahlke wrote: >"%PROGRAM_FILES%/Adblock Plus for IE" The biggest problem with this message is that there's no way (not that I could find) to give a different message based on a 32-bit or 64-bit platform. So a full technical disclosure is impossible with the current tool. Furthermore, I'm not ever sure that %...% substitution is even supported. The only reason I even know about the [...] substitution is that it was already used in the example code. There's no documentation about the syntax. Eric 2013/08/01 18:58:37 I'll do that. It also appears again below. Show quoted text On 2013/08/01 10:30:33, Wladimir Palant wrote: > This setup program installs [WixBundleName] to your "Program Files" directory I'll do that. It also appears again below.
	21 <String Id="InstallInstallButton">&Install</String>

	22 <String Id="InstallCloseButton">&Do not install</String>
	Wladimir Palant 2013/08/01 10:30:33 The user doesn't choose between installing and not The user doesn't choose between installing and not installing - that choice has been made already, Adblock Plus should be installed. So the second button should have a generic name, "Cancel" is the usual one IMHO. Also, I think that it should be called that on all screens (meaning no separate ProgressCancelButton string). Eric 2013/08/01 18:58:37 "Cancel" it is. Show quoted text On 2013/08/01 10:30:33, Wladimir Palant wrote: > So the second button should > have a generic name, "Cancel" is the usual one IMHO. "Cancel" it is. Show quoted text > Also, I think that it > should be called that on all screens (meaning no separate ProgressCancelButton > string). Sorry, can't change the string names. These are names hard-wired in the C# UI code.
	23

	24 <!-- Progress dialog -->

	25 <String Id="ProgressHeader">Setup Progress</String>

	26 <String Id="ProgressLabel">Processing:</String>

	27 <String Id="OverallProgressPackageText">Initializing...</String>

	28 <String Id="ProgressCancelButton">&Cancel install</String>

	29

	30 <!-- Modify dialog -->

	31 <String Id="ModifyHeader">Modify Setup</String>

	32 <String Id="ModifyNotice">Adblock Plus for IE is already installed on this mac hine. If it's not working correctly, you may repair it. You may also uninstall i t.</String>

	33 <String Id="ModifyRepairButton">&Repair</String>

	34 <String Id="ModifyUninstallButton">&Uninstall</String>

	35 <String Id="ModifyCloseButton">&Do nothing</String>
	Wladimir Palant 2013/08/01 10:30:33 Again, I would rather have a generic "Cancel" butt Again, I would rather have a generic "Cancel" button here.
	36

	37 <!-- Success dialog -->

	38 <String Id="SuccessHeader">Setup Successful</String>

	39 <String Id="SuccessLaunchButton">&Launch</String>
	Wladimir Palant 2013/08/01 10:30:33 Launch what exactly? This should probably say: "St Launch what exactly? This should probably say: "Start Internet Explorer" Eric 2013/08/01 18:58:37 This is the generic text. It's not invoked at pres Show quoted text On 2013/08/01 10:30:33, Wladimir Palant wrote: > Launch what exactly? This should probably say: "Start Internet Explorer" This is the generic text. It's not invoked at present. I left the definition here in case we use it. If we end up needing it, then what you've suggested is probably the right text.
	40 <String Id="SuccessRestartText">You must restart your computer before you can use the software.</String>

	41 <String Id="SuccessRestartButton">&Restart</String>

	42 <String Id="SuccessCloseButton">&Done</String>
	Wladimir Palant 2013/08/01 10:30:33 If we are asking the user to restart then the opti If we are asking the user to restart then the options should read "Restart Now" and "Restart Later" IMHO. Eric 2013/08/01 18:58:37 Again, these are not used. Again, these are not used.
	43

	44 <!-- Failure dialog -->

	45 <String Id="FailureHeader">Setup Failed</String>

	46 <String Id="FailureHyperlinkLogText">One or more issues caused the setup to fa il. Please fix the issues and then retry setup. For more information see the &lt ;a href="#">log file</a>.</String>

	47 <String Id="FailureRestartText">You must restart your computer to complete the rollback of the software.</String>

	48 <String Id="FailureRestartButton">&Restart</String>

	49 <String Id="FailureCloseButton">&Done</String>
	Wladimir Palant 2013/08/01 10:30:33 Same here, "Restart Now" and "Restart Later" in ca Same here, "Restart Now" and "Restart Later" in case of restart IMHO.
	50 </WixLocalization>

OLD	NEW

« installer/1031/bootstrap-theme.wxl ('K') | « installer/abp-64.png ('k') | installer/bootstrap-theme.xml » ('j') | installer/bootstrap-theme.xml » ('J')