FRP wrappers. "Update" menu item.

src/engine/main.cpp

 #include <AdblockPlus.h>
 #include <functional>
 #include <vector>
 #include <Windows.h>
 
 #include "../shared/AutoHandle.h"
 #include "../shared/Communication.h"
 #include "../shared/Dictionary.h"
 #include "../shared/Utils.h"
 #include "../shared/Version.h"
@@ skipping 22 matching lines @@
     for (int32_t i = 0; i < count; i++)
     {
       AdblockPlus::SubscriptionPtr subscription = subscriptions[i];
       response << subscription->GetProperty("url")->AsString()
                << subscription->GetProperty("title")->AsString()
                << subscription->GetProperty("specialization")->AsString()
                << subscription->IsListed();
     }
   }
   
-  bool updateAvailable;
+  bool updateAvailable = false;
   void UpdateCallback(const std::string res)
   {
     if (updateAvailable)
       return;
     Dictionary* dictionary = Dictionary::GetInstance();
     if (res.length() == 0)
     {
       std::wstring upToDateText = dictionary->Lookup("updater", "update-already-up-to-date-text");
       std::wstring upToDateTitle = dictionary->Lookup("updater", "update-already-up-to-date-title");
-      MessageBox(NULL, upToDateText.c_str(), upToDateTitle.c_str(), MB_OK);
+      MessageBox(NULL, upToDateText.c_str(), upToDateTitle.c_str(), MB_ICONINFORMATION);

[Wladimir Palant, 2013/08/13 09:19:51]

Not sure why but this change isn't present in the current code. But I agree with
Felix, it should be MB_OK | MB_ICONINFORMATION.

     }
     else
     {
       std::wstring errorText = dictionary->Lookup("updater", "update-error-text");
       std::wstring errorTitle = dictionary->Lookup("updater", "update-error-title");
       ReplaceString(errorText, L"?1?", ToUtf16String(res));
-      MessageBox(NULL, errorText.c_str(), errorTitle.c_str(), MB_OK);
+      MessageBox(NULL, errorText.c_str(), errorTitle.c_str(), MB_ICONEXCLAMATION);

[Wladimir Palant, 2013/08/13 09:19:51]

Not sure why but this change isn't present in the current code. But I agree with
Felix, it should be MB_OK | MB_ICONEXCLAMATION.

     }
-    return;

[Wladimir Palant, 2013/08/13 09:19:51]

This change isn't present in the current code.

   }
 
 
   CriticalSection firstRunLock;
   bool firstRunActionExecuted = false;
   Communication::OutputBuffer HandleRequest(Communication::InputBuffer& request)
   {
     Communication::OutputBuffer response;
 
     Communication::ProcType procedure;
@@ skipping 304 matching lines @@
     }
     catch (std::runtime_error e)
     {
       DebugException(e);
       return 1;
     }
   }
 
   return 0;
 }