src/engine/Updater.cpp - Issue 11304082: Download updates automatically, ask to install from a modeless dialog

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/engine/Updater.cpp

Issue 11304082: Download updates automatically, ask to install from a modeless dialog (Closed)

Left Patch Set: Created July 31, 2013, 7:16 p.m.

Right Patch Set: Calculate sizes dynamically Created Aug. 2, 2013, 10:47 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #include <functional>	1 #include <functional>

2 #include <memory>	2 #include <memory>

3 #include <sstream>	3 #include <sstream>

4	4

5 #include <Windows.h>	5 #include <Windows.h>

6	6

7 #include <AdblockPlus/FileSystem.h>	7 #include <AdblockPlus/FileSystem.h>

8 #include <AdblockPlus/WebRequest.h>	8 #include <AdblockPlus/WebRequest.h>

9	9

10 #include "../shared/AutoHandle.h"	10 #include "../shared/AutoHandle.h"

(...skipping 120 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
131 UpdateInstallDialog dialog;	131 UpdateInstallDialog dialog;

132 bool shouldInstall = dialog.Show();	132 bool shouldInstall = dialog.Show();

133 if (shouldInstall)	133 if (shouldInstall)

134 {	134 {

135 if (!InstallUpdate(tempFile))	135 if (!InstallUpdate(tempFile))

136 {	136 {

137 DebugLastError("Failed to install update");	137 DebugLastError("Failed to install update");

138 Dictionary* dictionary = Dictionary::GetInstance();	138 Dictionary* dictionary = Dictionary::GetInstance();

139 MessageBoxW(	139 MessageBoxW(

140 0, dictionary->Lookup("updater", "install-error-text").c_str(),	140 0, dictionary->Lookup("updater", "install-error-text").c_str(),

141 dictionary->Lookup("updater", "install-error-title").c_str(), MB_OK);	141 dictionary->Lookup("updater", "install-error-title").c_str(),
Wladimir Palant 2013/08/01 09:58:24 Add MB_ICONEXCLAMATION flag? Add MB_ICONEXCLAMATION flag? Felix Dahlke 2013/08/02 10:48:01 Done. Show quoted text On 2013/08/01 09:58:24, Wladimir Palant wrote: > Add MB_ICONEXCLAMATION flag? Done.
	142 MB_OK \| MB_ICONEXCLAMATION);

142 }	143 }

143 }	144 }

144 }	145 }

LEFT	RIGHT