Appear fast for IE

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
@@ skipping 135 matching lines @@
 
 }
 
 
 bool CPluginSettings::IsPluginEnabled() const
 {
   return m_isPluginEnabledTab;
 }
 
 
-std::map<CString, CString> CPluginSettings::GetFilterLanguageTitleList() const
-{
-  CPluginSettings::GetInstance()->m_subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();

[Felix Dahlke, 2013/08/07 09:34:49]

Why get the settings instance here? We're in a member function.

+std::map<CString, CString> CPluginSettings::GetFilterLanguageTitleList()
+{
+  m_subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();

[Wladimir Palant, 2013/08/13 09:41:02]

This should be a local variable, no point keeping it a member variable. This
method can stay const then.

 
   std::map<CString, CString> filterList;
   for (size_t i = 0; i < m_subscriptions.size(); i ++)
   {
     SubscriptionDescription it = m_subscriptions[i];
     filterList.insert(std::make_pair(CString(it.url.c_str()), CString(it.title.c_str())));
   }
   return filterList;
 }
 
@@ skipping 189 matching lines @@
 }
 
 CString CPluginSettings::GetDocumentationLink()
 {
   return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
 }
 
 
 
 #endif // SUPPORT_WHITELIST