Appear fast for IE

src/plugin/PluginTabBase.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClient.h"
 #include "PluginSettings.h"
 #ifdef SUPPORT_CONFIG
 #include "PluginConfig.h"
 #endif
 #include "PluginTab.h"
 #include "PluginDomTraverser.h"
 #include "PluginClass.h"
@@ skipping 11 matching lines @@
 int CPluginTabBase::s_whitelistVersion = 0;
 #endif
 #ifdef SUPPORT_CONFIG
 int CPluginTabBase::s_configVersion = 0;
 #endif
 
 
 CPluginTabBase::CPluginTabBase(CPluginClass* plugin) : m_plugin(plugin), m_isActivated(false)
 {
   m_filter = std::auto_ptr<CPluginFilter>(new CPluginFilter());
-  m_filter->hideFiltersLoadedEvent = CreateEvent(NULL, TRUE, FALSE, NULL);

[Felix Dahlke, 2013/08/07 09:34:49]

Since this is C++, we should use true and false instead of the defines.

+  m_filter->hideFiltersLoadedEvent = CreateEvent(NULL, true, false, NULL);
 
   CPluginClient* client = CPluginClient::GetInstance();
   if (client->GetIEVersion() < 10)
   {
     m_isActivated = true;
   }
 
   DWORD id;
   m_hThread = ::CreateThread(NULL, 0, ThreadProc, (LPVOID)this, CREATE_SUSPENDED, &id);
   if (m_hThread)
@@ skipping 33 matching lines @@
 {
   m_isActivated = true;
 }
 
 
 void CPluginTabBase::OnUpdate()
 {
   m_isActivated = true;
 }
 
 DWORD WINAPI FilterLoader(void* thisPtrVoid)

[Wladimir Palant, 2013/08/13 09:41:02]

Use LPVOID rather than void* to match ThreadProc signature? Right now you are
mixing Windows and C++ types.

 {
   CPluginTabBase* thisPtr = (CPluginTabBase*)thisPtrVoid;

[Wladimir Palant, 2013/08/13 09:41:02]

Given that there really is no "this" pointer here - I would prefer having the
variable names show what they refer to. Meaning e.g. tabBase and threadParam.

   thisPtr->m_filter->LoadHideFilters(CPluginClient::GetInstance()->GetElementHidingSelectors(thisPtr->GetDocumentDomain().GetString()));
   SetEvent(thisPtr->m_filter->hideFiltersLoadedEvent);
   return 0;
 }
 
 void CPluginTabBase::OnNavigate(const CString& url)
 {
   SetDocumentUrl(url);
 
 
 #ifdef SUPPORT_FRAME_CACHING
   ClearFrameCache(GetDocumentDomain());
 #endif
 
   std::wstring domainString = GetDocumentDomain();
   ResetEvent(m_filter->hideFiltersLoadedEvent);
   CreateThread(NULL, NULL, &FilterLoader, this, NULL, NULL);

[Felix Dahlke, 2013/08/07 13:23:03]

How I see it, this is the relevant change, right? The one that makes IE think
we're fast although we're not. I think it's worth adding a comment here on why
filters are being loaded in a separate thread.

[Oleksandr, 2013/08/07 16:07:40]

This is not the only relevant change. This is just done for IE not to show us as
a bottleneck of the navigation slowdown (the second value in the Menage Addons).
The first value (the load time) was influenced by us initializing the settings
in the main thread (SetSite essentially). So more like the relevant change is
the "always registering the mime filter, and only unregistering it if it was
disabled". That way we can initialize settings singleton elsewhere (since we
don't need to call the GetPref("enabled"..) in the main thread anymore.
On 2013/08/07 13:23:03, Felix H. Dahlke wrote:

 
 #ifdef SUPPORT_DOM_TRAVERSER
   m_traverser->ClearCache();
 #endif
 }
 
 void CPluginTabBase::OnDownloadComplete(IWebBrowser2* browser)
 {
 #ifdef SUPPORT_DOM_TRAVERSER
   if (!CPluginClient::GetInstance()->IsWhitelistedUrl(std::wstring(GetDocumentUrl())))
@@ skipping 243 matching lines @@
 
         // Non-hanging sleep
         Sleep(50);
       }
 
       tabLoopIteration++;
   }
 
   return 0;
 }