Fix 64-bit conversion errors

src/plugin/PluginClass.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClass.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
 #include "PluginMimeFilterClient.h"
 #include "PluginClient.h"
@@ skipping 971 matching lines @@
   m_hTabWnd = hTabWnd;
   m_hStatusBarWnd = hWndStatusBar;
   m_hPaneWnd = hWndNewPane;
 
   UpdateTheme();
 
   // Subclass status bar
   m_pWndProcStatus = (WNDPROC)SetWindowLongPtr(hWndStatusBar, GWLP_WNDPROC, (LPARAM)(WNDPROC)NewStatusProc);
 
   // Adjust pane
-  UINT nPartCount = ::SendMessage(m_hStatusBarWnd, SB_GETPARTS, 0, 0);
+  LRESULT nPartCount = ::SendMessage(m_hStatusBarWnd, SB_GETPARTS, 0, 0);
 
   if (nPartCount > 1)
   {
     INT *pData = new INT[nPartCount];
 
     ::SendMessage(m_hStatusBarWnd, SB_GETPARTS, nPartCount, (LPARAM)pData);
     ::SendMessage(m_hStatusBarWnd, SB_SETPARTS, nPartCount, (LPARAM)pData);
 
     delete[] pData;
   }
@@ skipping 380 matching lines @@
     if (client->IsWhitelistedUrl(std::wstring(GetTab()->GetDocumentUrl())))
     {
       fmii.fState = MFS_CHECKED | MFS_ENABLED;
     }
     else
     {
       fmii.fState = MFS_UNCHECKED | MFS_ENABLED;
     }
     fmii.fMask = MIIM_STRING | MIIM_STATE;
     fmii.dwTypeData = const_cast<LPWSTR>(ctext.c_str());
-    fmii.cch = ctext.size();
+    fmii.cch = static_cast<UINT>(ctext.size());
 
     ::SetMenuItemInfoW(hMenu, ID_MENU_DISABLE_ON_SITE, FALSE, &fmii);
   }
 #else
   {
     ::DeleteMenu(hMenu, ID_MENU_DISABLE_ON_SITE, FALSE);
   }
 #endif // SUPPORT_WHITELIST
 
   // Plugin update
   ctext = dictionary->Lookup("menu", "menu-update");
   fmii.fMask  = MIIM_STATE | MIIM_STRING;
   fmii.fState = client ? MFS_ENABLED : MFS_DISABLED;
   fmii.dwTypeData = const_cast<LPWSTR>(ctext.c_str());
-  fmii.cch = ctext.size();
+  fmii.cch = static_cast<UINT>(ctext.size());
   ::SetMenuItemInfoW(hMenu, ID_MENU_UPDATE, FALSE, &fmii);
 
 
   // Plugin enable
   ctext = dictionary->Lookup("menu", "menu-disable");
   if (settings->GetPluginEnabled())
   {
     fmii.fState = MFS_UNCHECKED | MFS_ENABLED;
   }
   else
   {
     fmii.fState = MFS_CHECKED | MFS_ENABLED;
   }
   fmii.fMask  = MIIM_STATE | MIIM_STRING;
   fmii.dwTypeData = const_cast<LPWSTR>(ctext.c_str());
-  fmii.cch = ctext.size();
+  fmii.cch = static_cast<UINT>(ctext.size());
   ::SetMenuItemInfoW(hMenu, ID_MENU_DISABLE, FALSE, &fmii);
 
   // Settings
   ctext = dictionary->Lookup("menu", "menu-settings");
   fmii.fMask  = MIIM_STATE | MIIM_STRING;
   fmii.fState = MFS_ENABLED;
   fmii.dwTypeData = const_cast<LPWSTR>(ctext.c_str());
-  fmii.cch = ctext.size();
+  fmii.cch = static_cast<UINT>(ctext.size());
   ::SetMenuItemInfoW(hMenu, ID_MENU_SETTINGS, FALSE, &fmii);
 
   return true;
 }
 
 
 STDMETHODIMP CPluginClass::Exec(const GUID*, DWORD nCmdID, DWORD, VARIANTARG*, VARIANTARG*)
 {
   HWND hBrowserWnd = GetBrowserHWND();
   if (!hBrowserWnd)
@@ skipping 102 matching lines @@
       break;
     }
 
   case SB_SETPARTS:
     {
       if (!lParam || !wParam || wParam > 30 || !IsWindow(pClass->m_hPaneWnd))
       {
         return CallWindowProc(pClass->m_pWndProcStatus, hWnd, message, wParam, lParam);
       }
 
-      int nParts = wParam;
+      int nParts = static_cast<int>(wParam);

[Wladimir Palant, 2013/08/17 09:10:07]

Do we need a cast here? From the look of it, using WPARAM type for nParts should
do (LocalAlloc takes SIZE_T which is pointer-sized - like WPARAM).

[Felix Dahlke, 2013/08/17 09:23:29]

It's not necessary, we can do numerical comparisons with numbers and pointers,
but I think the intent is clearer here when we cast this to int.

[Felix Dahlke, 2013/08/17 09:23:29]

Yes, the cast is not strictly speaking necessary, we could remove this
assignment and just use wParam to begin with. But I think it's clearer to cast
to the actual number type when we want to use it as a number.

[Wladimir Palant, 2013/08/17 09:43:04]

Well, WPARAM is still a number type even though it is no longer a single word
(originally it was, hence the name).

       if (STATUSBAR_PANE_NUMBER >= nParts)
       {
         return CallWindowProc(pClass->m_pWndProcStatus, hWnd, message, wParam, lParam);
       }
 
       HLOCAL hLocal = LocalAlloc(LHND, sizeof(int) * (nParts+1));
       LPINT lpParts = (LPINT)LocalLock(hLocal);
       memcpy(lpParts, (void*)lParam, wParam*sizeof(int));
 
       for (unsigned i = 0; i < STATUSBAR_PANE_NUMBER; i++)
@@ skipping 351 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }