Prepared adblockplus for Safari

chrome/content/ui/i18n.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-var i18n;
-if (typeof chrome != "undefined")
-{
-  i18n = chrome.i18n;
-}
-else
+var i18n = (window.ext && ext.i18n) || (window.chrome && chrome.i18n);

[Wladimir Palant, 2013/09/10 06:53:46]

This will produce a warning in JavaScript - you are accessing an undefined
property. Also, I don't really consider this code readable. So I would prefer
that you keep the original approach:

if (typeof chrome != "undefined")
  ...
else if (typeof ext != "undefined")
  ...
else

[Wladimir Palant, 2013/09/10 07:10:40]

A warning in Firefox is what I meant of course.

[Sebastian Noack, 2013/09/10 10:56:29]

I couldn't reproduce that. Accessing an undefined property just returns
undefined, which evaluates to false. The above code seems to work without any
warning, even in Firefox. I have tested it. Also I consider my code slightly
more readable, but I guess that is just a matter of taste.

[Wladimir Palant, 2013/09/10 11:10:14]

You need to enable javascript.option.strict preference which is generally
recommended when developing in Firefox (e.g. it will also warn about accessing
undeclared global variables).

[Sebastian Noack, 2013/09/10 14:20:57]

Sure, in strict mode that wouldn't work anymore. I wasn't aware that we are
using strict mode. And at least in i18n.js we apparently don't use it. But it
might make sense nevertheless to stay compatible with strict mode.

[Wladimir Palant, 2013/09/10 14:34:21]

That's just a development setting, not strict mode. We certainly want to switch
to strict mode eventually however.

+if (!i18n)
 {
   // Using Firefox' approach on i18n instead
 
   // Randomize URI to work around bug 719376
   var pageName = location.pathname.replace(/.*\//, '').replace(/\..*?$/, '');
   var stringBundle = Services.strings.createBundle("chrome://adblockplus/locale/" + pageName +
     ".properties?" + Math.random());
 
   function getI18nMessage(key)
   {
@@ skipping 97 matching lines @@
 
   var now = new Date();
   if (d.toDateString() == now.toDateString())
     return [timeString];
   else
     return [timeString, d.toLocaleDateString()];
 }
 
 // Fill in the strings as soon as possible
 window.addEventListener("DOMContentLoaded", loadI18nStrings, true);