Unified Diff: chrome/content/ui/firstRun.html
Issue 11533106:
Prepared adblockplus for Safari (Closed)
Patch Set:
Created Sept. 19, 2013, 2:27 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
chrome/content/ui/firstRun.js » ('j')
|
chrome/content/ui/firstRun.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/content/ui/firstRun.html |
| =================================================================== |
| --- a/chrome/content/ui/firstRun.html |
| +++ b/chrome/content/ui/firstRun.html |
| @@ -20,7 +20,16 @@ |
| <head> |
| <title class="i18n_firstRun_title"></title> |
| <meta charset="utf-8"> |
| + |
| + <!-- {% if type == 'safari' %} --> |
|
Felix Dahlke
2013/10/15 10:31:23
Why are the Jinja tags in HTML comments? I presume
Sebastian Noack
2013/10/18 14:40:41
See the discussion in the other review.
http://co
|
| + <!-- {{ '<link type="text/css" href="skin/firstRun.css" rel="stylesheet"/>' }} --> |
| + <!-- {% else %} --> |
|
Felix Dahlke
2013/10/15 10:31:23
How about something shorter like this instead?
<l
Sebastian Noack
2013/10/18 14:40:41
That wouldn't work, because for compatibility jinj
|
| <link type="text/css" href="/skin/firstRun.css" rel="stylesheet"/> |
| + <!-- {% endif %} --> |
| + |
| + <!-- {% if type in ('chrome', 'opera', 'safari') %} --> |
| + <!-- {{ '<script type="text/javascript" src="ext.js"></script>' }} --> |
| + <!-- {% endif %} --> |
| <script type="text/javascript" src="utils.js"></script> |
| <script type="text/javascript" src="i18n.js"></script> |
| <script type="text/javascript" src="firstRun.js"></script> |
| @@ -32,8 +41,8 @@ |
| <h1 id="title-main" class="i18n_firstRun_title"></h1> |
| </header> |
| + <p id="legacySafariWarning" class="i18n_firstRun_legacySafariWarning" hidden="true"></p> |
| <p id="dataCorruptionWarning" class="i18n_firstRun_dataCorruptionWarning" hidden="true"></p> |
| - |
| <p id="acceptableAdsExplanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
| <h2 id="features-title" class="i18n_firstRun_features"></h2> |
« no previous file with comments
|
« no previous file
|
chrome/content/ui/firstRun.js » ('j')
|
chrome/content/ui/firstRun.js » ('J')
