Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: Info.plist.tmpl

Issue 11544056: Prepared buildtools for Safari (Closed)
Patch Set: Created Sept. 9, 2013, 9:25 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | background.html.tmpl » ('j') | build.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">
3 <plist version="1.0">
4 <dict>
5 <key>CFBundleDisplayName</key>
Wladimir Palant 2013/09/10 10:15:27 Nit: We generally use two spaces for indentation,
6 <string>{{ name }}</string>
7 <key>CFBundleIdentifier</key>
8 <string>{{ identifier }}</string>
Wladimir Palant 2013/09/10 10:15:27 I suggest generating the identifier automatically
Sebastian Noack 2013/09/10 12:40:43 I assumed that the templates (or buildtools in gen
Wladimir Palant 2013/09/10 14:02:12 Well, we hardcode the devbuild URLs already so the
9 <key>CFBundleInfoDictionaryVersion</key>
10 <string>6.0</string>
11 <key>CFBundleShortVersionString</key>
12 <string>{{ version }}</string>
Wladimir Palant 2013/09/10 10:15:27 According to Apple documentation we shouldn't be u
13 <key>CFBundleVersion</key>
14 <string>{{ version }}</string>
15 <key>Chrome</key>
16 <dict>
17 <key>Database Quota</key>
18 <real>104857600</real>
19 <key>Global Page</key>
20 <string>background.html</string>
21 {%- if menus %}
22 <key>Menus</key>
23 <array>
24 {%- for identifier, items in menus.iteritems() %}
25 <dict>
26 <key>Identifier</key>
27 <string>{{ identifier }}</string>
28 <key>Menu Items</key>
29 <array>
30 {%- for identifier, props in items.iteritems() %}
31 <dict>
32 <key>Identifier</key>
33 <string>{{ identifier }}</string >
34 {%- for key, value in props.iteritems() %}
35 <key>{{ key }}</key>
36 {{ value }}
37 {%- endfor %}
38 </dict>
39 {%- endfor %}
40 </array>
41 </dict>
42 {%- endfor %}
43 </array>
44 {%- endif %}
45 {%- if popovers %}
46 <key>Popovers</key>
47 <array>
48 {%- for identifier, props in popovers.iteritems() %}
49 <dict>
50 <key>Identifier</key>
51 <string>{{ identifier }}</string>
52 {%- for key, value in props.iteritems() %}
53 <key>{{ key }}</key>
54 {{ value }}
55 {%- endfor %}
56 </dict>
57 {%- endfor %}
58 </array>
59 {%- endif %}
60 {%- if toolbarItems %}
61 <key>Toolbar Items</key>
62 <array>
63 {%- for identifier, props in toolbarItems.iteritems() %}
64 <dict>
65 <key>Identifier</key>
66 <string>{{ identifier }}</string>
67 {%- for key, value in props.iteritems() %}
Wladimir Palant 2013/09/10 10:15:27 Having Jinja tags unindented makes the whole thing
68 <key>{{ key }}</key>
69 {{ value }}
70 {%- endfor %}
71 </dict>
72 {%- endfor %}
73 </array>
74 {%- endif %}
75 </dict>
76 <key>Content</key>
77 <dict>
78 <key>Scripts</key>
79 <dict>
80 <key>End</key>
81 <array>
82 {%- for script in contentScripts.end %}
83 <string>{{ script }}</string>
84 {%- endfor %}
85 </array>
86 <key>Start</key>
87 <array>
88 {%- for script in contentScripts.start %}
89 <string>{{ script }}</string>
90 {%- endfor %}
91 </array>
92 </dict>
93 </dict>
94 <key>ExtensionInfoDictionaryVersion</key>
95 <string>1.0</string>
96 <key>Permissions</key>
97 <dict>
98 <key>Website Access</key>
99 <dict>
100 {%- if allowedDomains and not allowAllDomains %}
101 <key>Allowed Domains</key>
102 <array>
103 {%- for domain in allowedDomains %}
104 <string>{{ domain }}</string>
105 {%- endfor %}
106 </array>
107 {%- endif %}
108 <key>Include Secure Pages</key>
109 {%- if allowSecurePages %}
110 <true/>
111 {%- else %}
112 <false/>
113 {%- endif %}
114 <key>Level</key>
115 {%- if allowAllDomains %}
116 <string>All</string>
117 {%- elif allowedDomains %}
118 <string>Some</string>
119 {%- else %}
120 <string>None</string>
121 {%- endif %}
122 </dict>
123 </dict>
124 <key>Description</key>
125 <string>{{ description }}</string>
126 {%- if author %}
127 <key>Author</key>
128 <string>{{ author }}</string>
129 {%- endif %}
130 {%- if website %}
131 <key>Website</key>
132 <string>{{ website }}</string>
133 {%- endif %}
134 {%- if updateURL %}
135 <key>Update Manifest URL</key>
136 <string>{{ updateURL }}</string>
137 {%- endif %}
Wladimir Palant 2013/09/10 10:15:27 There should always be an update URL for developme
138 </dict>
139 </plist>
OLDNEW
« no previous file with comments | « no previous file | background.html.tmpl » ('j') | build.py » ('J')

Powered by Google App Engine
This is Rietveld