Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: background.html.tmpl
Issue
11544056
:
Prepared buildtools for Safari (Closed)
Patch Set: Addressed comments
Created Oct. 30, 2013, 5:22 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Prepared buildtools for Safari
Patch Set 3:
Patch Set 4:
Patch Set 5:
Patch Set 6:
Patch Set 7: Added ext directory to includedFiles for chrome and extensions based on it.
Patch Set 8: Made "Chrome" be not replaced with "Safari" in the warning on the first run page
Patch Set 9: Addressed comments
Patch Set 10: Made first run page always generated, fix absolute URLs for Safari during build, introduced browser…
Patch Set 11: Fixed regex for fixing absolute URLs in Safari
Patch Set 12:
Right:
Patch Set 1: None
Patch Set 2: Prepared buildtools for Safari
Patch Set 3:
Patch Set 4:
Patch Set 5:
Patch Set 6:
Patch Set 7: Added ext directory to includedFiles for chrome and extensions based on it.
Patch Set 8: Made "Chrome" be not replaced with "Safari" in the warning on the first run page
Patch Set 9: Addressed comments
Patch Set 10: Made first run page always generated, fix absolute URLs for Safari during build, introduced browser…
Patch Set 11: Fixed regex for fixing absolute URLs in Safari
Patch Set 12:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Info.plist.tmpl
background.html.tmpl
build.py
imageConversion.py
packager.py
packagerChrome.py
packagerSafari.py
safariInfo.js.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« Info.plist.tmpl
('k') |
build.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<head>
3
{%- for script in backgroundScripts %}
4
<script type="application/javascript" src="{{ script }}"></script>
5
{%- endfor %}
6
</head>
7
<body>
8
</body>
9
</html>
OLD
NEW
« no previous file with comments
|
« Info.plist.tmpl
('k') |
build.py »
('j') |
no next file with comments »
Edit Message
Issue 11544056: Prepared buildtools for Safari (Closed)
Created Sept. 4, 2013, 8:03 a.m. by Sebastian Noack
Modified Oct. 31, 2013, 4:29 p.m.
Reviewers: Wladimir Palant, Felix Dahlke
Base URL:
Comments: 104
This is Rietveld