Prepared buildtools for Safari

safariInfo.js.tmpl

 /*
  * This file is part of the Adblock Plus build tools,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 require.scopes.info = {
   addonID: '',
   addonName: {{ metadata.get('general', 'basename')|json }},
   addonVersion: {{ version|json }},
   addonRoot: '',
 
-{%- for x in ('application', 'platform') %}

[Wladimir Palant, 2013/09/10 10:15:27]

I think that the platform here is "webkit", not "safari" (the applications
building on that platform would be "safari" and "mobilesafari"). But even if the
fields were the same, I would certainly prefer get applicationVersion() { return
this.platformVersion; } to this loop.

[Sebastian Noack, 2013/09/10 12:40:43]

I've no idea what application and platform is supposed to be. I've looked at the
chromeInfo.js and on Chrome application is always "chrome" and platform
"chromium", both with the chrome (not webkit) version number. So I'm a little
confused now. :/

[Wladimir Palant, 2013/09/10 14:02:12]

"application" is the specific application. "platform" is normally a platform
that multiple applications using the same extension mechanism share. Given that
Safari is currently the only application using that extension mechanism using
"safari" as the platform name might make sense of course - other WebKit-based
application aren't exactly running on the same platform indeed.

[Felix Dahlke, 2013/09/11 14:44:35]

Voting for using "safari" as the platform name.

-  {{ x }}: 'safari',
-  get {{ x }}Version() {
+  application: 'safari',
+  get applicationVersion() {
     return navigator.userAgent.match(/Version\/([\d.]+)/)[1];
-  }{% if not loop.last %},{% endif %}
-{%- endfor %}
+  },
+  platform: 'safari',
+  get platformVersion() {
+    return this.applicationVersion;
+  }
 };