build.py - Issue 11544056: Prepared buildtools for Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: build.py

Issue 11544056: Prepared buildtools for Safari (Closed)

Patch Set: Made "Chrome" be not replaced with "Safari" in the warning on the first run page Created Oct. 25, 2013, 4:55 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build.py

===================================================================

--- a/build.py

+++ b/build.py

@@ -18,7 +18,7 @@

import os, sys, re, subprocess, buildtools

from getopt import getopt, GetoptError

-knownTypes = ('gecko', 'chrome', 'opera')

+knownTypes = ('gecko', 'chrome', 'opera', 'safari')

class Command(object):

name = property(lambda self: self._name)

@@ -200,6 +200,9 @@

packager.createBuild(baseDir, type=type, outFile=outFile, buildNum=buildNum,

releaseBuild=releaseBuild, keyFile=keyFile,

experimentalAPI=experimentalAPI)

+ elif type == 'safari':

+ import buildtools.packagerSafari as packager

+ packager.createBuild(baseDir, type=type, outFile=outFile, buildNum=buildNum, releaseBuild=releaseBuild, keyFile=keyFile)

Wladimir Palant 2013/10/30 13:36:01 Nit: restricting line length to 80 characters here

def runAutoInstall(baseDir, scriptName, opts, args, type):

@@ -425,11 +428,11 @@

command.params = '[options] [output_file]'

command.addOption('Only include the given locales (if omitted: all locales not marked as incomplete)', short='l', long='locales', value='l1,l2,l3', types=('gecko'))

command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')

- command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('gecko', 'chrome', 'opera'))

+ command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('gecko', 'chrome', 'opera', 'safari'))

command.addOption('Create a build for leak testing', short='m', long='multi-compartment', types=('gecko'))

command.addOption('Create a release build', short='r', long='release')

command.addOption('Enable use of experimental APIs', long='experimental')

- command.supportedTypes = ('gecko', 'chrome', 'opera')

+ command.supportedTypes = ('gecko', 'chrome', 'opera', 'safari')

with addCommand(runAutoInstall, 'autoinstall') as command:

command.shortDescription = 'Install extension automatically'

« no previous file with comments | « background.html.tmpl ('k') | imageConversion.py » ('j') | imageConversion.py » ('J')