webrequest.js - Issue 11579001: Workaround for Chrome not specifying which request is main_frame under some circumstances

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: webrequest.js

Issue 11579001: Workaround for Chrome not specifying which request is main_frame under some circumstances (Closed)

Patch Set: Created Aug. 28, 2013, 12:50 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: webrequest.js

===================================================================

--- a/webrequest.js

+++ b/webrequest.js

@@ -56,7 +56,10 @@

return {};

var type = details.type;

- if (type == "main_frame" || type == "sub_frame")

+ // Workaround: Under some circumstances Chrome 29+ gives top frame the

+ // type "object" instead of "main_frame". We work around that by assuming

+ // that the first request belongs to the top frame.

+ if (type == "main_frame" || type == "sub_frame" || !(details.tabId in frames))

recordFrame(details.tabId, details.frameId, details.parentFrameId, details.url);

if (type == "main_frame")

« no previous file with comments | « no previous file | no next file » | no next file with comments »