Bunch of tiny fixes

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
@@ skipping 134 matching lines @@
   return lang;
 
 }
 
 
 bool CPluginSettings::IsPluginEnabled() const
 {
   return GetPluginEnabled();
 }
 
 

[Oleksandr, 2013/09/05 22:47:40]

http://codereview.adblockplus.org/11427013/diff/8001/src/plugin/PluginSetting...

-std::map<CString, CString> CPluginSettings::GetFilterLanguageTitleList()
+std::map<CString, CString> CPluginSettings::GetFilterLanguageTitleList() const
 {
-  m_subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();
+  std::vector<SubscriptionDescription> subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();
 
   std::map<CString, CString> filterList;
-  for (size_t i = 0; i < m_subscriptions.size(); i ++)
+  for (size_t i = 0; i < subscriptions.size(); i ++)
   {
-    SubscriptionDescription it = m_subscriptions[i];
+    SubscriptionDescription it = subscriptions[i];
     filterList.insert(std::make_pair(CString(it.url.c_str()), CString(it.title.c_str())));
   }
   return filterList;
 }
 
 bool CPluginSettings::IsWorkingThread(DWORD dwThreadId) const
 {
   if (dwThreadId == 0)
   {
     dwThreadId = ::GetCurrentThreadId();
@@ skipping 157 matching lines @@
 }
 
 CString CPluginSettings::GetDocumentationLink()
 {
   return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
 }
 
 
 
 #endif // SUPPORT_WHITELIST