Fixed: WindowObserver ignoring primary browser window if instantiated before window visible

lib/windowObserver.js

 /*
  * This file is part of the Adblock Plus build tools,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
  * @param {String} [when]   when to execute applyToWindow(). "start" means immediately
  *                          when the window opens, "ready" when its contents are available
  *                          and "end" (default) means to wait until the "load" event.
  * @constructor
  */
 function WindowObserver(listener, when)
 {
   this._listener  = listener;
   this._when = when;
 
-  let e = Services.ww.getWindowEnumerator();

[Wladimir Palant, 2013/09/09 08:04:22]

You are reverting the change I made for
https://bugzilla.mozilla.org/show_bug.cgi?id=819561. I don't think that this is
the best possible solution.

+  let windows = [];
+  let e = Services.wm.getZOrderDOMWindowEnumerator(null, true);
   while (e.hasMoreElements())
+    windows.push(e.getNext());
+
+  // Check if there are any windows that we missed
+  let eAll = Services.ww.getWindowEnumerator();
+  while (eAll.hasMoreElements())
   {
-    let window = e.getNext().QueryInterface(Ci.nsIDOMWindow);
+    let element = eAll.getNext();
+    if (windows.indexOf(element) < 0)
+      windows.push(element);
+  }
+  
+  for (let i = 0; i < windows.length; i++)
+  {
+    let window = windows[i].QueryInterface(Ci.nsIDOMWindow);
     if (when == "start" || window.document.readyState == "complete")
       this._listener.applyToWindow(window);
     else
       this.observe(window, "chrome-document-global-created", null);
   }
 
   Services.obs.addObserver(this, "chrome-document-global-created", true);
 
   this._shutdownHandler = function()
   {
@@ skipping 38 matching lines @@
         window.removeEventListener(event, listener, false);
         if (this._shutdownHandler)
           this._listener.applyToWindow(window);
       }.bind(this);
       window.addEventListener(event, listener, false);
     }
   },
 
   QueryInterface: XPCOMUtils.generateQI([Ci.nsISupportsWeakReference, Ci.nsIObserver])
 };