Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: popup.html

Issue 11627039: Added ad counting functionality (Closed)
Left Patch Set: Changed strings & using appLocale Created Sept. 18, 2013, 9:45 a.m.
Right Patch Set: Created Sept. 20, 2013, 3 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « metadata.chrome ('k') | stats.js » ('j') | stats.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <!-- 3 <!--
4 - This file is part of Adblock Plus <http://adblockplus.org/>, 4 - This file is part of Adblock Plus <http://adblockplus.org/>,
5 - Copyright (C) 2006-2013 Eyeo GmbH 5 - Copyright (C) 2006-2013 Eyeo GmbH
6 - 6 -
7 - Adblock Plus is free software: you can redistribute it and/or modify 7 - Adblock Plus is free software: you can redistribute it and/or modify
8 - it under the terms of the GNU General Public License version 3 as 8 - it under the terms of the GNU General Public License version 3 as
9 - published by the Free Software Foundation. 9 - published by the Free Software Foundation.
10 - 10 -
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 .ui-button { 70 .ui-button {
71 padding: 3px; 71 padding: 3px;
72 } 72 }
73 73
74 .spacer { 74 .spacer {
75 height: 7px; 75 height: 7px;
76 width: 5px; 76 width: 5px;
77 display: block; 77 display: block;
78 } 78 }
79 79
80 #statsStuff 80 #statsContainer
Wladimir Palant 2013/09/18 13:22:17 #statsContainer? :)
81 { 81 {
82 margin: 10px 5px; 82 margin: 10px 5px;
83 padding: 5px; 83 padding: 5px;
84 border: 1px solid rgb(150, 150, 200); 84 border: 1px solid rgb(150, 150, 200);
85 border-radius: 5px; 85 border-radius: 5px;
86 white-space: nowrap; 86 white-space: nowrap;
87 background: -webkit-linear-gradient(top, rgb(250, 250, 255), rgb(200, 200, 255 ) 50px); 87 background: -webkit-linear-gradient(rgb(250, 250, 255), rgb(200, 200, 255) 50p x);
88 background: linear-gradient(top, rgb(250, 250, 255), rgb(200, 200, 255) 50px); 88 background: linear-gradient(rgb(250, 250, 255), rgb(200, 200, 255) 50px);
Wladimir Palant 2013/09/18 13:22:17 This isn't valid linear-gradient syntax, see https
89 } 89 }
90 90
91 #statsPage > strong, 91 #statsPage > strong,
92 #statsTotal > strong 92 #statsTotal > strong
93 { 93 {
94 display: inline-block; 94 display: inline-block;
95 min-width: 30px; 95 min-width: 50px;
Wladimir Palant 2013/09/18 13:22:17 Hm, we'll easily see six-digit numbers here... May
96 color: rgb(255, 50, 50); 96 color: rgb(255, 50, 50);
97 text-align: right; 97 text-align: right;
98 } 98 }
99 99
100 #share 100 #share
101 { 101 {
102 display: block; 102 display: block;
103 color: rgb(75, 75, 200); 103 color: rgb(75, 75, 200);
104 text-align: right; 104 text-align: right;
105 text-decoration: underline; 105 text-decoration: underline;
106 } 106 }
107 107
108 #shareBox > a 108 #shareBox > a
109 { 109 {
110 display: block; 110 display: block;
111 margin-top: 5px; 111 margin-top: 5px;
112 } 112 }
113 </style> 113 </style>
114 114
115 <script type="text/javascript" src="jquery-ui/js/jquery-1.7.1.min.js"></script> 115 <script type="text/javascript" src="jquery-ui/js/jquery-1.7.1.min.js"></script>
116 <script type="text/javascript" src="i18n.js"></script> 116 <script type="text/javascript" src="i18n.js"></script>
117 <script type="text/javascript" src="popup.js"></script> 117 <script type="text/javascript" src="popup.js"></script>
118 <script type="text/javascript" src="notification.js"></script> 118 <script type="text/javascript" src="notification.js"></script>
119 <script type="text/javascript" src="stats.js"></script> 119 <script type="text/javascript" src="stats.js"></script>
120 </head> 120 </head>
121 <body id="main"> 121 <body id="main">
122
123 <div id="notification" style="display: none"> 122 <div id="notification" style="display: none">
124 <h1 id="title"></h1> 123 <h1 id="title"></h1>
125 <p id="message"></p> 124 <p id="message"></p>
126 </div> 125 </div>
127 126
128 <div id="enabledCheckboxAndLabel" style="display:none"><input id="enabled" type= "checkbox" checked><label for="enabled"><span class="i18n_enabled_for_site"></sp an></label></div> 127 <div id="enabledCheckboxAndLabel" style="display:none"><input id="enabled" type= "checkbox" checked><label for="enabled"><span class="i18n_enabled_for_site"></sp an></label></div>
129 <div id="clickHideInactiveStuff" style="display: none"> 128 <div id="clickHideInactiveStuff" style="display: none">
130 <div class="spacer"></div> 129 <div class="spacer"></div>
131 <button id="clickHideButton" class="ui-button ui-widget ui-state-default ui-corn er-all ui-button-text-only"><span class="i18n_easy_create_filter"></span></butto n> 130 <button id="clickHideButton" class="ui-button ui-widget ui-state-default ui-corn er-all ui-button-text-only"><span class="i18n_easy_create_filter"></span></butto n>
132 </div> 131 </div>
133 132
134 <div id="clickHideActiveStuff" style="display: none"> 133 <div id="clickHideActiveStuff" style="display: none">
135 <div id="clickHideMsg"><span class="i18n_clickhide_instructions"></span></div> 134 <div id="clickHideMsg"><span class="i18n_clickhide_instructions"></span></div>
136 <div class="spacer"></div> 135 <div class="spacer"></div>
137 <button id="cancelButton" class="ui-button ui-widget ui-state-default ui-corner- all ui-button-text-only"><span class="i18n_cancel"></span></button> 136 <button id="cancelButton" class="ui-button ui-widget ui-state-default ui-corner- all ui-button-text-only"><span class="i18n_cancel"></span></button>
138 </div> 137 </div>
139 138
140 <div id="statsStuff" hidden> 139 <div id="statsContainer" hidden>
141 <strong class="i18n_stats_title"></strong> 140 <strong class="i18n_stats_title"></strong>
142 <div id="stats"> 141 <div id="stats">
143 <div id="statsPage" class="i18n_stats_label_page label"></div> 142 <div id="statsPage" class="label"></div>
144 <div id="statsTotal" class="i18n_stats_label_total label"></div> 143 <div id="statsTotal" class="label"></div>
Wladimir Palant 2013/09/18 13:22:17 Please remove the i18n classes here, just fill the
145 </div> 144 </div>
146 <div> 145 <div>
147 <a id="share" class="i18n_stats_share_title" href="#"></a> 146 <a id="share" class="i18n_stats_share_title" href="#"></a>
148 <div id="shareBox" hidden> 147 <div id="shareBox" hidden>
149 <a class="i18n_stats_share_label_fb ui-button ui-widget ui-state-default u i-corner-all" data-social="facebook"></a> 148 <a class="i18n_stats_share_label_fb ui-button ui-widget ui-state-default u i-corner-all" data-social="facebook"></a>
150 <a id="shareTwitter" class="i18n_stats_share_label_twitter ui-button ui-wi dget ui-state-default ui-corner-all" data-social="twitter"></a> 149 <a id="shareTwitter" class="i18n_stats_share_label_twitter ui-button ui-wi dget ui-state-default ui-corner-all" data-social="twitter"></a>
151 <a id="shareGplus" class="i18n_stats_share_label_gplus ui-button ui-widget ui-state-default ui-corner-all" data-social="gplus"></a> 150 <a id="shareGplus" class="i18n_stats_share_label_gplus ui-button ui-widget ui-state-default ui-corner-all" data-social="gplus"></a>
152 </div> 151 </div>
153 </div> 152 </div>
154 </div> 153 </div>
155 154
156 </div> 155 </div>
157 </body> 156 </body>
158 </html> 157 </html>
LEFTRIGHT
« metadata.chrome ('k') | stats.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld