Added ad counting functionality

_locales/en_US/messages.json

Index: _locales/en_US/messages.json
===================================================================
--- a/_locales/en_US/messages.json
+++ b/_locales/en_US/messages.json
@@ -103,6 +103,48 @@
   "show_icon": {
     "message": "Show icon in address bar"
   },
+  "stats_label_page": {
+    "description": "This is the suffix for the page stats in the popup.",
+    "message": "on this page"
+  },
+  "stats_label_total": {
+    "description": "This is the suffix for the total stats in the popup.",
+    "message": "in total"
+  },

[Wladimir Palant, 2013/09/18 08:37:32]

No suffixes please - languages other than English can have an entirely different
word order, what you consider a suffix won't be a suffix there (try translating
into German). Note that even in English these suffixes aren't placed correctly.

In general, you should never build together sentences in the application. The
translators should always deal with full sentences. In other words, we want to
have two sentences translated:

I blocked $number$ ads on $page$ thanks to Adblock Plus.

I blocked $number$ ads in total thanks to Adblock Plus.

A few things to note:

* "on this page" lacks context information, the page needs to be mentioned
explicitly. 
* Sentences have to end with a period.
* A proper placeholder is used for the number here. I don't know why you decided
to introduce your own placeholder format while we are discussing merging the two
that currently exist.
* Inserting a number into a sentence is generally problematic and should be
avoided if somehow possible. In English we can assume that we always need to use
plural - the rules are way more complicated in other languages however and are
impossible to capture in a single translation.

[Thomas Greiner, 2013/09/18 09:48:25]

This is only used in the following context and not in a sentence:

Blocked ads:
12 on this page
21 in total

I changed it to "<strong>$number$</strong> in total" and
"<strong>$number$</strong> on this page" because the number needs to be
highlighted.

+  "stats_over": {
+    "description": "This is prepended to the stats numbers that are within a certain range.",
+    "message": "over $number$!",

[Felix Dahlke, 2013/09/17 09:41:04]

I love this :D

Wondering whether we should put the exclamation mark in parentheses:
"I blocked over 9000(!) ads and trackers thanks to Adblock Plus"

[Thomas Greiner, 2013/09/17 11:26:15]

Done.

[Wladimir Palant, 2013/09/18 08:37:32]

Note that the joke will be lost in translation. Also, simply replacing
"$number$" with "over $number$(!)" might not be possible in every language due
to inflections of other words. The description should explain what this is about
and suggest translating this with "$number$" if in doubt. In general, the
description shouldn't be vague - the translators need to understand what they
are translating:

"For some numbers the stats share message will say 'I blocked over 123 ads'
instead of 'I blocked 123 ads'. This is a reference to the 'over 9000' meme.
This string can be translated simply with '$number$' if that meme isn't known to
the speakers of the language or if the resulting sentence would sound weird
otherwise."

+    "placeholders": {
+      "number": {
+        "content": "$1"
+      }
+    }
+  },
+  "stats_share_download": {
+    "description": "Label for link to adblockplus.org",

[Wladimir Palant, 2013/09/18 08:37:32]

"Label for the link to adblockplus.org in the share message"?

[Thomas Greiner, 2013/09/18 09:48:25]

For Facebook we have the ability to add an extra link as an action to the share
message (will be displayed similar as "Comment", "Like" and such actions).

[Wladimir Palant, 2013/09/18 09:56:48]

Sure. The description should indicate the context however - and the context is
the share message here. The important information is that this isn't something
we display in our UI.

+    "message": "Download Adblock Plus"
+  },
+  "stats_share_label": {
+    "description": "This is the button label for the share action in the popup.",
+    "message": "Share on $network$",

[Wladimir Palant, 2013/09/18 08:37:32]

We've inherited some overly wordy and useless message descriptions from AdThwart
- we don't really need to do it like that however. IMHO it's pretty obvious
what's being translated here. The only piece of information required concerns
the $network$ placeholder - what does it represent?

Yet I don't think that we should have that placeholder at all. Depending on
language the network name can be inflected. In other words, we should have
multiple messages: "Share on Facebook", "Share on Twitter" etc.

+    "placeholders": {
+      "network": {
+        "content": "$1"
+      }
+    }
+  },
+  "stats_share_message": {
+    "description": "This is the message that can be shared through the popup.",

[Wladimir Palant, 2013/09/18 08:37:32]

Again, that description doesn't contain any useful information. How about:

"This message will be posted to social networks if the user decides to share his
stats."

+    "message": "I blocked _TOTAL_ ads and trackers thanks to Adblock Plus"

[Felix Dahlke, 2013/09/17 09:41:04]

I think this needs a bit of work, probably better discussed on the forum or in a
quick meeting than in a review IMO.

Anyway, my angle: We have the chance to make these numbers less bogus here by
saying something like: "Adblock Plus blocked _TOTAL_ ad and tracking elements".
But is that too technical?

[Thomas Greiner, 2013/09/17 11:26:15]

We decided on keeping it simple. Even saying "tracking elements" isn't really
accurate due to it only counting blocked requests.

+  },
+  "stats_share_title": {
+    "description": "This is the label for the share action in the popup.",

[Wladimir Palant, 2013/09/18 08:37:32]

I think this description needs to explain the difference between
stats_share_title and stats_share_label.

+    "message": "Share this"
+  },
+  "stats_title": {
+    "description": "This is the title for the stats section in the popup.",

[Wladimir Palant, 2013/09/18 08:37:32]

"Title of the stats section in the popup" should be enough as a description (the
shorter it is, the more likely that people will actually read it).

+    "message": "Blocked ads:"

[Felix Dahlke, 2013/09/17 09:41:04]

As above, might want to be a bit more precise here. "Blocked ad and tracking
elements"? Not sure.

[Thomas Greiner, 2013/09/17 11:26:15]

As above we want to keep it simple even though I agree that this is not
accurately explaining what the numbers mean, adding more text would clutter the
UI.

+  },
   "subscriptionSelection_subscriptionSelector_label": {
     "message": "Please choose a filter subscription from the list:"
   },