Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplus.gyp

Issue 11756012: Enhanced Protected Mode support (Closed)
Left Patch Set: Created Sept. 15, 2013, 1 a.m.
Right Patch Set: Addressing comments Created Sept. 17, 2013, 2:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | installer/bho_registry_value.wxi » ('j') | installer/bho_registry_value.wxi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['defaults.gypi'], 2 'includes': ['defaults.gypi'],
3 3
4 'variables': { 4 'variables': {
5 'build_type%': 'devbuild', 5 'build_type%': 'devbuild',
6 'build_version%': '', 6 'build_version%': '',
7 'shared_files': [ 7 'shared_files': [
8 'src/shared/AutoHandle.cpp', 8 'src/shared/AutoHandle.cpp',
9 'src/shared/Communication.cpp', 9 'src/shared/Communication.cpp',
10 'src/shared/Dictionary.cpp', 10 'src/shared/Dictionary.cpp',
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 }, 65 },
66 }, 66 },
67 67
68 { 68 {
69 'target_name': 'AdblockPlus', 69 'target_name': 'AdblockPlus',
70 'type': 'shared_library', 70 'type': 'shared_library',
71 'sources': [ 71 'sources': [
72 'src/plugin/AdblockPlusClient.cpp', 72 'src/plugin/AdblockPlusClient.cpp',
73 'src/plugin/AdblockPlusDomTraverser.cpp', 73 'src/plugin/AdblockPlusDomTraverser.cpp',
74 'src/plugin/AdblockPlusTab.cpp', 74 'src/plugin/AdblockPlusTab.cpp',
75 'src/plugin/NotificationMessage.cpp',
76 'src/plugin/Plugin.cpp', 75 'src/plugin/Plugin.cpp',
77 'src/plugin/PluginClass.cpp', 76 'src/plugin/PluginClass.cpp',
78 'src/plugin/PluginClientBase.cpp', 77 'src/plugin/PluginClientBase.cpp',
79 'src/plugin/PluginClientFactory.cpp', 78 'src/plugin/PluginClientFactory.cpp',
80 'src/plugin/PluginDebug.cpp', 79 'src/plugin/PluginDebug.cpp',
81 'src/plugin/PluginFilter.cpp', 80 'src/plugin/PluginFilter.cpp',
82 'src/plugin/PluginMimeFilterClient.cpp', 81 'src/plugin/PluginMimeFilterClient.cpp',
83 'src/plugin/PluginMutex.cpp', 82 'src/plugin/PluginMutex.cpp',
84 'src/plugin/PluginSettings.cpp', 83 'src/plugin/PluginSettings.cpp',
85 'src/plugin/PluginStdAfx.cpp', 84 'src/plugin/PluginStdAfx.cpp',
86 'src/plugin/PluginSystem.cpp', 85 'src/plugin/PluginSystem.cpp',
87 'src/plugin/PluginTabBase.cpp', 86 'src/plugin/PluginTabBase.cpp',
88 'src/plugin/PluginUserSettings.cpp', 87 'src/plugin/PluginUserSettings.cpp',
89 'src/plugin/PluginUtil.cpp', 88 'src/plugin/PluginUtil.cpp',
90 'src/plugin/PluginWbPassThrough.cpp', 89 'src/plugin/PluginWbPassThrough.cpp',
91 'src/plugin/AdblockPlus.def', 90 'src/plugin/AdblockPlus.def',
92 'src/plugin/AdblockPlus.idl', 91 'src/plugin/AdblockPlus.idl',
93 'src/plugin/AdblockPlus.rc', 92 'src/plugin/AdblockPlus.rc',
94 'src/plugin/AdblockPlus.rgs', 93 'src/plugin/AdblockPlus.rgs',
95 '<@(shared_files)', 94 '<@(shared_files)',
96 ], 95 ],
97 'include_dirs': [ 96 'include_dirs': [
98 '$(WindowsSDK_IncludePath)', 97 '$(WindowsSDK_IncludePath)',
99 '$(VCInstallDir)atlmfc/include', 98 '$(VCInstallDir)atlmfc/include',
100 '$(WINDDKDIR)/inc/atl71', 99 '$(WINDDKDIR)/inc/atl71',
101 ], 100 ],
102 'defines': ['PRODUCT_ADBLOCKPLUS', 'ISOLATION_AWARE_ENABLED'], 101 'defines': ['PRODUCT_ADBLOCKPLUS'],
103 'libraries': [ 102 'libraries': [
104 '-latlthunk', 103 '-latlthunk',
105 '-lwinhttp', 104 '-lwinhttp',
106 '-lshell32', 105 '-lshell32',
107 '-lComctl32',
108 ], 106 ],
109 'configurations': { 107 'configurations': {
110 # 'libraries' is not allowed under 'configurations' :-( 108 # 'libraries' is not allowed under 'configurations' :-(
111 'Debug': { 109 'Debug': {
112 'msvs_settings': { 110 'msvs_settings': {
113 'VCLinkerTool': { 111 'VCLinkerTool': {
114 'AdditionalDependencies': ['atlsd.lib'], 112 'AdditionalDependencies': ['atlsd.lib'],
115 }, 113 },
116 }, 114 },
117 }, 115 },
(...skipping 10 matching lines...) Expand all
128 'conditions': [[ 126 'conditions': [[
129 'target_arch=="ia32"', { 127 'target_arch=="ia32"', {
130 'AdditionalLibraryDirectories': [ 128 'AdditionalLibraryDirectories': [
131 '$(VCInstallDir)atlmfc/lib', 129 '$(VCInstallDir)atlmfc/lib',
132 '$(WindowsSDK_LibraryPath_x86)', 130 '$(WindowsSDK_LibraryPath_x86)',
133 '$(WINDDKDIR)/lib/ATL/i386', 131 '$(WINDDKDIR)/lib/ATL/i386',
134 ], 132 ],
135 }, { 133 }, {
136 'AdditionalLibraryDirectories': [ 134 'AdditionalLibraryDirectories': [
137 '$(VCInstallDir)atlmfc/lib/amd64', 135 '$(VCInstallDir)atlmfc/lib/amd64',
136 '$(WindowsSDK_LibraryPath_x64)',
138 '$(WINDDKDIR)/lib/ATL/amd64', 137 '$(WINDDKDIR)/lib/ATL/amd64',
Wladimir Palant 2013/09/16 13:45:07 Nit: probably makes sense to have the order of ent
139 '$(WindowsSDK_LibraryPath_x64)',
140 ], 138 ],
141 } 139 }
142 ]], 140 ]],
143 'DelayLoadDLLs': ['Shell32.dll'], 141 'DelayLoadDLLs': ['Shell32.dll'],
144 }, 142 },
145 }, 143 },
146 }, 144 },
147 145
148 { 146 {
149 'target_name': 'tests', 147 'target_name': 'tests',
(...skipping 11 matching lines...) Expand all
161 'libraries': ['-ladvapi32', '-lshell32', '-lole32'], 159 'libraries': ['-ladvapi32', '-lshell32', '-lole32'],
162 }, 160 },
163 'msvs_settings': { 161 'msvs_settings': {
164 'VCLinkerTool': { 162 'VCLinkerTool': {
165 'SubSystem': '1', # Console 163 'SubSystem': '1', # Console
166 'EntryPointSymbol': 'mainCRTStartup', 164 'EntryPointSymbol': 'mainCRTStartup',
167 }, 165 },
168 }, 166 },
169 }] 167 }]
170 } 168 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld