Expose string insertion functionality from i18n.js to public

chrome/content/ui/i18n.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 64 matching lines @@
         catch(e)
         {
           Cu.reportError(e);
           return "Missing translation: " + key;
         }
       }
     };
   })();
 }
 
-// Loads and inserts i18n strings into matching elements. Any inner HTML already in the
-// element is parsed as JSON and used as parameters to substitute into placeholders in the
-// i18n message.
-function loadI18nStrings()
+// Inserts i18n strings into matching elements. Any inner HTML already in the element is
+// parsed as JSON and used as parameters to substitute into placeholders in the i18n
+// message.
+var setElementText = i18n.setElementText = function(element, stringName, arguments)

[Wladimir Palant, 2013/09/24 12:45:46]

Given that this is loaded into global context I suggest leaving out "var
setElementText" and only define this function on i18n. loadI18nStrings() can
call it via i18n object as well.

 {
   function processString(str, element)
   {
     var match = /^(.*?)<(a|strong)>(.*?)<\/\2>(.*)$/.exec(str);
     if (match)
     {
       processString(match[1], element);
 
       var e = document.createElement(match[2]);
       processString(match[3], e);
       element.appendChild(e);
 
       processString(match[4], element);
     }
     else
       element.appendChild(document.createTextNode(str));
   }
 
+  while (element.lastChild)
+    element.removeChild(element.lastChild);
+  processString(i18n.getMessage(stringName, arguments), element);
+}
+
+// Loads i18n strings
+function loadI18nStrings()
+{
   var nodes = document.querySelectorAll("[class^='i18n_']");
   for(var i = 0; i < nodes.length; i++)
   {
     var node = nodes[i];
     var arguments = JSON.parse("[" + node.textContent + "]");
     if (arguments.length == 0)
       arguments = null;
 
     var className = node.className;
     if (className instanceof SVGAnimatedString)
       className = className.animVal;
     var stringName = className.split(/\s/)[0].substring(5);
 
-    while (node.lastChild)
-      node.removeChild(node.lastChild);
-    processString(i18n.getMessage(stringName, arguments), node);
+    setElementText(node, stringName, arguments);
   }
 }
 
 // Provides a more readable string of the current date and time
 function i18n_timeDateStrings(when)
 {
   var d = new Date(when);
   var timeString = d.toLocaleTimeString();
 
   var now = new Date();
   if (d.toDateString() == now.toDateString())
     return [timeString];
   else
     return [timeString, d.toLocaleDateString()];
 }
 
 // Fill in the strings as soon as possible
 window.addEventListener("DOMContentLoaded", loadI18nStrings, true);