Fixed: Total blocked count was not saved across multiple sessions

lib/stats.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
   }
   else
     return (key in Prefs.stats_total ? Prefs.stats_total[key] : 0);
 };
 
 FilterNotifier.addListener(function(action, item, newValue, oldValue, tabId)
 {
   if (action != "filter.hitCount")
     return;
   
-  let statsTotal = Prefs.stats_total;
+  var blocked = item instanceof BlockingFilter;
   
   // Increment counts
-  if (item instanceof BlockingFilter)
+  if (blocked)
   {
-    if ("blocked" in statsTotal)
-      statsTotal.blocked++;
+    if ("blocked" in Prefs.stats_total)
+      Prefs.stats_total.blocked++;
     else
-      statsTotal.blocked = 1;

[Wladimir Palant, 2013/10/02 09:26:26]

Adding Prefs.stats_total = Prefs.stats_total; here to notify Prefs of a change
is actually sufficient, all the other changes are unnecessary.

+      Prefs.stats_total.blocked = 1;
+    Prefs.stats_total = Prefs.stats_total;
     
     let frameData = getFrameData(tabId, 0);
     if (frameData)
     {
       if ("blocked" in frameData)
         frameData.blocked++;
       else
         frameData.blocked = 1;
     }
   }
-  
-  Prefs.stats_total = statsTotal;
 });