Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: modules/nagios/files/sudoers
Issue
12375002
:
Implement more detailed bandwidth monitoring (Closed)
Left Patch Set:
Created Oct. 1, 2013, 5:30 p.m.
Right Patch Set: Fixed comments
Created Oct. 10, 2013, 9:36 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Do not account for Ethernet overhead
Patch Set 3: Fixed permissions
Patch Set 4: Increased socket timeout and offloaded time calculations to tcpdump
Patch Set 5: Fixed comments
Right:
Patch Set 1: None
Patch Set 2: Do not account for Ethernet overhead
Patch Set 3: Fixed permissions
Patch Set 4: Increased socket timeout and offloaded time calculations to tcpdump
Patch Set 5: Fixed comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
manifests/monitoringserver.pp
modules/nagios/files/check_bandwidth
modules/nagios/files/sudoers
modules/nagios/manifests/client.pp
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« modules/nagios/files/check_bandwidth
('k') |
modules/nagios/manifests/client.pp »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
nagios ALL=(root) NOPASSWD:/usr/sbin/tcpdump
LEFT
RIGHT
« modules/nagios/files/check_bandwidth
('k') |
modules/nagios/manifests/client.pp »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 12375002: Implement more detailed bandwidth monitoring (Closed)
Created Oct. 1, 2013, 5:30 p.m. by Wladimir Palant
Modified Nov. 8, 2013, 8:07 a.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 21
This is Rietveld