Fix memory leaks in libadblockplus

include/AdblockPlus/V8ValueHolder.h

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
       reset(value.isolate, static_cast<v8::Handle<T> >(value));
     }
     V8ValueHolder(v8::Isolate* isolate, v8::Persistent<T> value)
     {
       reset(isolate, value);
     }
     V8ValueHolder(v8::Isolate* isolate, v8::Handle<T> value)
     {
       reset(isolate, value);
     }
-
+    ~V8ValueHolder()
+    {
+      if (this->value.get())
+      {
+        this->value->Dispose(this->isolate);
+        this->value.reset(0);
+      }

[Wladimir Palant, 2013/10/08 08:12:19]

Better avoid the code duplication here:

reset(0, new v8::Persistent<T>());

+    }
     void reset(v8::Isolate* isolate, v8::Persistent<T> value)
     {
       if (this->value.get())
       {
         this->value->Dispose(this->isolate);
         this->value.reset(0);
       }
 
       if (!value.IsEmpty())
       {
@@ skipping 19 matching lines @@
     {
       return *value;
     }
   private:
     v8::Isolate* isolate;
     std::auto_ptr<v8::Persistent<T> > value;
   };
 }
 
 #endif