include/AdblockPlus/FilterEngine.h - Issue 23127017: Consider the frame structure in Matches()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: include/AdblockPlus/FilterEngine.h

Issue 23127017: Consider the frame structure in Matches() (Closed)

Left Patch Set: Created Oct. 29, 2013, 3:13 p.m.

Right Patch Set: Better test coverage Created Nov. 15, 2013, 8:15 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <http://adblockplus.org/>,	2 * This file is part of Adblock Plus <http://adblockplus.org/>,

3 * Copyright (C) 2006-2013 Eyeo GmbH	3 * Copyright (C) 2006-2013 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 void SetFilterChangeCallback(FilterChangeCallback callback);	92 void SetFilterChangeCallback(FilterChangeCallback callback);

93 void RemoveFilterChangeCallback();	93 void RemoveFilterChangeCallback();

94	94

95 private:	95 private:

96 JsEnginePtr jsEngine;	96 JsEnginePtr jsEngine;

97 bool initialized;	97 bool initialized;

98 bool firstRun;	98 bool firstRun;

99 int updateCheckId;	99 int updateCheckId;

100	100

101 void InitDone(JsValueList& params);	101 void InitDone(JsValueList& params);

	102 FilterPtr CheckFilterMatch(const std::string& url,

	103 const std::string& contentType,

	104 const std::string& documentUrl) const;

102 void UpdateCheckDone(const std::string& eventName, UpdaterCallback callback, JsValueList& params);	105 void UpdateCheckDone(const std::string& eventName, UpdaterCallback callback, JsValueList& params);

103 void FilterChanged(FilterChangeCallback callback, JsValueList& params);	106 void FilterChanged(FilterChangeCallback callback, JsValueList& params);

104 };	107 };

105 }	108 }

106	109

107 #endif	110 #endif

LEFT	RIGHT