iconAnimation.js - Issue 29317001: Relocated icon and redesigned icon popup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: iconAnimation.js

Issue 29317001: Relocated icon and redesigned icon popup (Closed)

Patch Set: Rebased Created Nov. 19, 2013, 1:43 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <http://adblockplus.org/>,	2 * This file is part of Adblock Plus <http://adblockplus.org/>,

3 * Copyright (C) 2006-2013 Eyeo GmbH	3 * Copyright (C) 2006-2013 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 111 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
122 if (this._step > 0)	122 if (this._step > 0)

123 {	123 {

124 var suffix = "-notification-" + this._severity;	124 var suffix = "-notification-" + this._severity;

125	125

126 if (this._step < 10)	126 if (this._step < 10)

127 suffix += "-" + this._step;	127 suffix += "-" + this._step;

128	128

129 path = path.replace(/(?=\..+$)/, suffix);	129 path = path.replace(/(?=\..+$)/, suffix);

130 }	130 }

131	131

132 tab.pageAction.setIcon(path);	132 tab.browserAction.setIcon(path);

133 }	133 }

134 };	134 };

OLD	NEW