Unified Diff: safari/background.js
Issue 29317001:
Relocated icon and redesigned icon popup (Closed)
Patch Set: Rebased
Created Nov. 19, 2013, 1:43 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« popup.js ('K')
|
« popup.js ('k')
|
skin/background-main-hover.png » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: safari/background.js |
| =================================================================== |
| --- a/safari/background.js |
| +++ b/safari/background.js |
| @@ -77,8 +77,7 @@ |
| this._tab.activate(); |
| }, |
| sendMessage: sendMessage, |
| - pageAction: { |
| - // there are no page actions in safari, so we use toolbar items instead |
| + browserAction: { |
| setIcon: function(path) |
| { |
| safari.extension.toolbarItems[0].image = safari.extension.baseURI + path; |
| @@ -88,9 +87,11 @@ |
| safari.extension.toolbarItems[0].toolTip = title; |
| }, |
| - // toolbar items in safari can"t get hidden |
| + // Safari does not provide these functionalities |
| hide: function() {}, |
| - show: function() {} |
| + show: function() {}, |
| + setBadgeBackgroundColor: function(color) {}, |
| + setBadgeText: function(text) {} |
|
Sebastian Noack
2013/11/19 15:27:54
It turned out that Safari actually can show a badg
Thomas Greiner
2013/11/26 17:50:51
Done.
|
| } |
| }; |
« popup.js ('K')
|
« popup.js ('k')
|
skin/background-main-hover.png » ('j')
|
no next file with comments »
