Unified Diff: safari/background.js
Issue 29317001:
Relocated icon and redesigned icon popup (Closed)
Patch Set: Addressed Felix' comments
Created Dec. 3, 2013, 12:04 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« popup.js ('k')
|
skin/background-main-hover.png » ('j')
|
skin/popup.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: safari/background.js |
| =================================================================== |
| --- a/safari/background.js |
| +++ b/safari/background.js |
| @@ -77,8 +77,7 @@ |
| this._tab.activate(); |
| }, |
| sendMessage: sendMessage, |
| - pageAction: { |
| - // there are no page actions in safari, so we use toolbar items instead |
| + browserAction: { |
| setIcon: function(path) |
| { |
| safari.extension.toolbarItems[0].image = safari.extension.baseURI + path; |
| @@ -87,10 +86,15 @@ |
| { |
| safari.extension.toolbarItems[0].toolTip = title; |
| }, |
| + setBadgeNumber: function(number) |
| + { |
| + safari.extension.toolbarItems[0].badge = (number === null) ? 0 : number; |
| + }, |
| - // toolbar items in safari can"t get hidden |
| + // Safari does not provide these functionalities |
| hide: function() {}, |
| - show: function() {} |
| + show: function() {}, |
| + setBadgeBackgroundColor: function(color) {} |
| } |
| }; |
« no previous file with comments
|
« popup.js ('k')
|
skin/background-main-hover.png » ('j')
|
skin/popup.css » ('J')
