background.js - Issue 29317001: Relocated icon and redesigned icon popup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 29317001: Relocated icon and redesigned icon popup (Closed)

Patch Set: Created Dec. 11, 2013, 1:08 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -110,7 +110,7 @@

var activeNotification = null;

-// Adds or removes page action icon according to options.

+// Adds or removes browser action icon according to options.

function refreshIconAndContextMenu(tab)

{

if(!/^https?:/.test(tab.url))

@@ -128,15 +128,15 @@

iconFilename = excluded ? "icons/abp-19-whitelisted.png" : "icons/abp-19.png";

}

- tab.pageAction.setIcon(iconFilename);

- tab.pageAction.setTitle(ext.i18n.getMessage("name"));

+ tab.browserAction.setIcon(iconFilename);

+ tab.browserAction.setTitle(ext.i18n.getMessage("name"));

iconAnimation.registerTab(tab, iconFilename);

if (localStorage.shouldShowIcon == "false")

- tab.pageAction.hide();

+ tab.browserAction.hide();

else

- tab.pageAction.show();

+ tab.browserAction.show();

if (require("info").platform == "chromium") // TODO: Implement context menus for Safari

// Set context menu status according to whether current tab has whitelisted domain

« no previous file with comments | « _locales/en_US/messages.json ('k') | chrome/background.js » ('j') | no next file with comments »