Issue 2681 - Fixed: Thunderbird 38 is listed twice on the requirements page

globals/get_browser_versions.py

 import re
 import os
 import sys
 import json
 import urllib
 import errno
 import logging
 import time
 from xml.dom import minidom
 
@@ skipping 200 matching lines @@
         if cached_current != current:
           previous = cached_current
         else:
           previous = cached_versions['previous']
       versions['previous'] = previous
 
       # Remove duplicates from unreleased versions. Occasionally,
       # different channels are on the same version, but we want
       # to list each version only once.
       versions['unreleased'] = sorted(
-        set(versions['unreleased']) - {current, previous},
+        set(versions['unreleased']) - set(re.sub(r'(\.0*)+$', '', ver) for ver in (current, previous) if ver),

[saroyanm, 2015/06/15 09:35:24]

Why we always check for the re.sub(r'(\.0*) ? What about if the stable version
will be Thunderbird 38.1 ?

[Sebastian Noack, 2015/06/15 09:39:53]

The beta channel will be updated to 39, before 38.1 is going to be released.
Though I agree that it would make sense to only consider the major number when
excluding duplicates for Thunderbird. However, that won't work for other
applications like Yandex.Browser.

[saroyanm, 2015/06/15 09:55:48]

LGTM

         key=key_by_version
       )
 
       versions['timestamp'] = now
       persistent_cache[browser] = versions
       file.seek(0)
       json.dump(persistent_cache, file)
       file.truncate()
 
   if not versions['previous']:
     logging.warning("Couldn't determine previous browser version, "
                     'please set %s.previous in %s', browser, filename)
 
   cache[browser] = versions
   return versions