Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 29317015: Issue 2625 - [cms] Crowdin synchronisation script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by kzar
Modified:
4 years, 4 months ago
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2625 - [cms] Crowdin synchronisation script

Patch Set 1 #

Total comments: 64

Patch Set 2 : Addressed Wladimir's feedback #

Total comments: 42

Patch Set 3 : Addressed further feedback #

Patch Set 4 : Slightly simplified request exception logic #

Total comments: 39

Patch Set 5 : Addressed Sebastian's feedback #

Total comments: 6

Patch Set 6 : Addressed more feedback from Sebastian #

Total comments: 7

Patch Set 7 : Addressed even more feedback from Sebastian #

Total comments: 3

Patch Set 8 : Give query_params a default value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -16 lines) Patch
M README.md View 1 2 2 chunks +39 lines, -0 lines 0 comments Download
A cms/bin/translate.py View 1 2 3 4 5 6 7 1 chunk +300 lines, -0 lines 0 comments Download
M cms/converters.py View 1 2 3 4 4 chunks +16 lines, -9 lines 0 comments Download
M cms/sources.py View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M cms/utils.py View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 24
kzar
Patch Set 1 https://codereview.adblockplus.org/29317015/diff/29317016/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29317015/diff/29317016/cms/converters.py#newcode128 cms/converters.py:128: def localize_string(self, name, default, comment, localedata, ...
4 years, 5 months ago (2015-06-15 14:24:28 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py#newcode19 cms/bin/translate.py:19: from itertools import islice Nit: I'm not a big ...
4 years, 5 months ago (2015-06-29 19:05:38 UTC) #2
kzar
Patch Set 2 : Addressed Wladimir's feedback https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py#newcode19 cms/bin/translate.py:19: from itertools ...
4 years, 5 months ago (2015-07-02 12:33:14 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests I see, we use "requests", because urllib ...
4 years, 5 months ago (2015-07-08 13:03:21 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests I just realized that simply using built-in ...
4 years, 5 months ago (2015-07-08 14:23:00 UTC) #5
kzar
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests On 2015/07/08 14:23:00, Sebastian Noack wrote: > ...
4 years, 5 months ago (2015-07-08 15:26:41 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests On 2015/07/08 15:26:41, kzar wrote: > On ...
4 years, 5 months ago (2015-07-08 15:43:50 UTC) #7
Wladimir Palant
https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py#newcode222 cms/bin/translate.py:222: required_locales, skipped_locales = ensure_required_locales( On 2015/07/02 12:33:11, kzar wrote: ...
4 years, 5 months ago (2015-07-08 23:11:09 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests On 2015/07/08 23:11:05, Wladimir Palant wrote: > ...
4 years, 5 months ago (2015-07-09 21:26:55 UTC) #9
Wladimir Palant
https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/bin/translate.py#newcode26 cms/bin/translate.py:26: import requests On 2015/07/09 21:26:55, Sebastian Noack wrote: > ...
4 years, 5 months ago (2015-07-10 21:24:05 UTC) #10
kzar
Patch Set 3 : Addressed further feedback https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29317016/cms/bin/translate.py#newcode222 cms/bin/translate.py:222: required_locales, skipped_locales ...
4 years, 5 months ago (2015-07-11 19:21:18 UTC) #11
kzar
Patch Set 4 : Slightly simplified request exception logic
4 years, 5 months ago (2015-07-12 05:49:15 UTC) #12
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29321284/cms/sources.py File cms/sources.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/sources.py#newcode173 cms/sources.py:173: result = collections.OrderedDict() On 2015/07/11 19:21:18, kzar wrote: > ...
4 years, 4 months ago (2015-07-14 11:31:08 UTC) #13
kzar
Patch Set 5 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29317015/diff/29321284/cms/sources.py File cms/sources.py (right): https://codereview.adblockplus.org/29317015/diff/29321284/cms/sources.py#newcode173 cms/sources.py:173: result = ...
4 years, 4 months ago (2015-07-14 12:54:31 UTC) #14
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29322015/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322015/cms/bin/translate.py#newcode61 cms/bin/translate.py:61: timeout=urllib3.Timeout(connect=5) On 2015/07/14 12:54:30, kzar wrote: > On 2015/07/14 ...
4 years, 4 months ago (2015-07-14 14:39:29 UTC) #15
kzar
Patch Set 6 : Addressed more feedback from Sebastian https://codereview.adblockplus.org/29317015/diff/29322015/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322015/cms/bin/translate.py#newcode61 cms/bin/translate.py:61: ...
4 years, 4 months ago (2015-07-15 09:51:25 UTC) #16
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py#newcode52 cms/bin/translate.py:52: request_method, str(url), **kwargs Converting url to an str object ...
4 years, 4 months ago (2015-07-15 10:31:04 UTC) #17
kzar
Patch Set 7 : Addressed even more feedback from Sebastian https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py#newcode52 ...
4 years, 4 months ago (2015-07-15 11:09:03 UTC) #18
Sebastian Noack
LGTM https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322352/cms/bin/translate.py#newcode52 cms/bin/translate.py:52: request_method, str(url), **kwargs On 2015/07/15 11:09:03, kzar wrote: ...
4 years, 4 months ago (2015-07-15 11:27:12 UTC) #19
Wladimir Palant
Feel free to address the nit below. LGTM if you don't. https://codereview.adblockplus.org/29317015/diff/29322374/cms/bin/translate.py File cms/bin/translate.py (right): ...
4 years, 4 months ago (2015-07-16 12:17:23 UTC) #20
Sebastian Noack
https://codereview.adblockplus.org/29317015/diff/29322374/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322374/cms/bin/translate.py#newcode44 cms/bin/translate.py:44: def raw_request(self, request_method, api_endpoint, query_params, **kwargs): On 2015/07/16 12:17:23, ...
4 years, 4 months ago (2015-07-16 12:23:56 UTC) #21
kzar
Patch Set 8 : Give query_params a default value https://codereview.adblockplus.org/29317015/diff/29322374/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29317015/diff/29322374/cms/bin/translate.py#newcode44 cms/bin/translate.py:44: ...
4 years, 4 months ago (2015-07-16 12:49:32 UTC) #22
Sebastian Noack
Even more LGTM
4 years, 4 months ago (2015-07-16 12:51:21 UTC) #23
Wladimir Palant
4 years, 4 months ago (2015-07-16 13:25:10 UTC) #24
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5