Issue 2693 - Update adblockplus dependency

test/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 76 matching lines @@
       serverResponse.responseText = responseText;
       return serverResponse;
     }
   };
 
 #ifdef NotificationMockWebRequestTest_ENABLED
   class NotificationMockWebRequestTest : public BaseJsTest
   {
   protected:
     FilterEnginePtr filterEngine;
+    bool isNotificationCallbackCalled;
     void SetUp()
     {
       BaseJsTest::SetUp();
       isNotificationCallbackCalled = false;
       jsEngine->SetFileSystem(
         std::tr1::shared_ptr<LazyFileSystem>(new LazyFileSystem()));
       const char* responseJsonText = "{"
         "\"notifications\": [{"
           "\"id\": \"some id\","
           "\"type\": \"information\","
           "\"message\": {"
              "\"en-US\": \"message\""
           "},"
           "\"title\": \"Title\""
         "}]"
         "}";
       jsEngine->SetWebRequest(std::tr1::shared_ptr<MockWebRequest>(
         new MockWebRequest(responseJsonText)));
       jsEngine->SetLogSystem(LogSystemPtr(new DefaultLogSystem()));
       filterEngine.reset(new FilterEngine(jsEngine));
       filterEngine->SetShowNotificationCallback(
-        std::bind(&NotificationMockWebRequestTest::onNotification,
+        std::bind(&NotificationMockWebRequestTest::OnNotification,
         this, std::tr1::placeholders::_1));
     }
 
-    void onNotification(const NotificationPtr& notification)

[Felix Dahlke, 2015/07/02 13:23:13]

Nit: Function names should start with an upper case character.

+    void OnNotification(const NotificationPtr& notification)
     {
       isNotificationCallbackCalled = true;
       ASSERT_TRUE(notification);
       EXPECT_EQ(NotificationType::NOTIFICATION_TYPE_INFORMATION, notification->GetType());
       EXPECT_EQ("Title", notification->GetTitle());
       EXPECT_EQ("message", notification->GetMessageString());
       notification->MarkAsShown();
     }
-    bool isNotificationCallbackCalled;

[Felix Dahlke, 2015/07/02 13:23:13]

Optional nit: Possibly just personal preference, but we already define a member
above, filterEngine - we normally group variable declarations. Up to you though.

   };
 #endif
 }
 
 TEST_F(NotificationTest, NoNotifications)
 {
   EXPECT_FALSE(PeekNotification());
 }
 
 #ifdef NotificationMockWebRequestTest_ENABLED
@@ skipping 62 matching lines @@
 TEST_F(NotificationTest, Links)
 {
   AddNotification("{ id: 'id', links: ['link1', 'link2'] }");
   NotificationPtr notification = PeekNotification();
   ASSERT_TRUE(notification);
   std::vector<std::string> notificationLinks = notification->GetLinks();
   ASSERT_EQ(2, notificationLinks.size());
   EXPECT_EQ("link1", notificationLinks[0]);
   EXPECT_EQ("link2", notificationLinks[1]);
 }