Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/FilterEngine.cpp

Issue 29317074: Issue 2693 - Update adblockplus dependency (Closed)
Patch Set: address comments Created July 1, 2015, 11:43 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/FilterEngine.cpp
diff --git a/src/FilterEngine.cpp b/src/FilterEngine.cpp
index 8a1660f7b7583b55ea75762ee9d823836caec659..abcb948cdec2c71a0cada858ae97477f55b857b8 100644
--- a/src/FilterEngine.cpp
+++ b/src/FilterEngine.cpp
@@ -257,15 +257,30 @@ std::vector<SubscriptionPtr> FilterEngine::FetchAvailableSubscriptions() const
return result;
}
-NotificationPtr FilterEngine::GetNextNotificationToShow(const std::string& url)
+void FilterEngine::ShowNextNotification(const std::string& url)
{
- JsValuePtr func = jsEngine->Evaluate("API.getNextNotificationToShow");
+ JsValuePtr func = jsEngine->Evaluate("API.showNextNotification");
JsValueList params;
if (!url.empty())
{
params.push_back(jsEngine->NewValue(url));
}
- return Notification::JsValueToNotification(func->Call(params));
+ func->Call(params);
+}
+
+void FilterEngine::SetShowNotificationCallback(const ShowNotificationCallback& value)
+{
+ if (!value)
+ return;
+
+ jsEngine->SetEventCallback("_showNotification",
+ std::tr1::bind(&FilterEngine::ShowNotification, this, value,
+ std::tr1::placeholders::_1));
+}
+
+void FilterEngine::RemoveShowNotificationCallback()
+{
+ jsEngine->RemoveEventCallback("_showNotification");
}
AdblockPlus::FilterPtr FilterEngine::Matches(const std::string& url,
@@ -414,6 +429,16 @@ void FilterEngine::FilterChanged(FilterEngine::FilterChangeCallback callback, Js
callback(action, item);
}
+void FilterEngine::ShowNotification(const ShowNotificationCallback& callback,
+ const JsValueList& params)
+{
+ if (params.size() < 1)
+ return;
+
+ callback(Notification::JsValueToNotification(params[0]));
+}
+
+
int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2)
{
JsValueList params;
« no previous file with comments | « libadblockplus.gyp ('k') | test/Notification.cpp » ('j') | test/Notification.cpp » ('J')

Powered by Google App Engine
This is Rietveld