Issue 1490 - Enable pre-configurable properties in Internet Explorer

src/plugin/PluginClass.cpp

Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -915,6 +915,10 @@
 
 void CPluginClass::FirstRunThread()
 {
+  // Just return if the First Run Page should be suppressed
+  if (CPluginClient::GetInstance()->GetPref(L"suppress_first_run_page", false))

[Eric, 2015/06/19 14:51:41]

I dislike the way that default values for preferences are spread throughout the
code rather than localized in 'libadblockplus'. It's really a design defect,
because it means that each client of 'libadblockplus' has to get the defaults
consistent with each other.

If that design defect were fixed, there would be no need for the second argument
here.

I understand that this might be considered out of scope. But since we're working
on preferences generally, now would be a good time to correct the flaw.

[Oleksandr, 2015/06/22 08:27:53]

I agree, but yes, I think it's out of scope here.

+    return;
+
   CoInitialize(NULL);
   VARIANT vFlags;
   vFlags.vt = VT_I4;