Issue 2711 - Refactored ChainedConfigParser, allowing manipulation of list items

packager.py

 # coding: utf-8
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Note: These are the base functions common to all packagers, the actual
 # packagers are implemented in packagerGecko and packagerChrome.
 
 import sys, os, re, codecs, subprocess, json, zipfile
 from StringIO import StringIO
 from chainedconfigparser import ChainedConfigParser
 
 import buildtools
 
 def getDefaultFileName(metadata, version, ext):
   return '%s-%s.%s' % (metadata.get('general', 'basename'), version, ext)
 
 def getMetadataPath(baseDir, type):
   return os.path.join(baseDir, 'metadata.%s' % type)
 
 def readMetadata(baseDir, type):
-  return ChainedConfigParser(getMetadataPath(baseDir, type))
+  parser = ChainedConfigParser()
+  parser.read(getMetadataPath(baseDir, type))
+  return parser
 
 def getBuildNum(baseDir):
   try:
     from buildtools.ensure_dependencies import Mercurial, Git
     if Mercurial().istype(baseDir):
       result = subprocess.check_output(['hg', 'id', '-R', baseDir, '-n'])
       return re.sub(r'\D', '', result)
     elif Git().istype(baseDir):
       result = subprocess.check_output(['git', 'rev-list', 'HEAD'], cwd=baseDir)
       return len(result.splitlines())
@@ skipping 89 matching lines @@
     names = self.keys()
     names.sort(key=sortKey)
     for name in names:
       zip.writestr(name, self[name])
     zip.close()
 
   def zipToString(self, sortKey=None):
     buffer = StringIO()
     self.zip(buffer, sortKey=sortKey)
     return buffer.getvalue()