Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29321013: Issue 2682 - Fix GAE dispatcher default port handling (Closed)

Created:
June 23, 2015, 8:04 a.m. by mathias
Modified:
July 9, 2015, 8:42 a.m.
CC:
Fred, Felix Dahlke
Visibility:
Public.

Description

Issue 2682 - Fix GAE dispatcher default port handling

Patch Set 1 #

Patch Set 2 : Issue 2682 - Fix GAE dispatcher default port handling #

Total comments: 20

Patch Set 3 : Issue 2682 - Fix GAE dispatcher default port handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M modules/rietveld/files/wrapper.py View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 19
mathias
June 23, 2015, 8:04 a.m. (2015-06-23 08:04:08 UTC) #1
mathias
Removed fragments left from testing but not required
June 23, 2015, 8:06 a.m. (2015-06-23 08:06:38 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode206 modules/rietveld/files/wrapper.py:206: def dispatch_tasks_to_user_port(): This function name is inaccurate. This function ...
June 23, 2015, 9:40 a.m. (2015-06-23 09:40:28 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode206 modules/rietveld/files/wrapper.py:206: def dispatch_tasks_to_user_port(): I'd rather go with fix_target_resolution(). https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode219 modules/rietveld/files/wrapper.py:219: ...
June 23, 2015, 9:53 a.m. (2015-06-23 09:53:10 UTC) #4
mathias
June 23, 2015, 10:12 a.m. (2015-06-23 10:12:48 UTC) #5
mathias
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode206 modules/rietveld/files/wrapper.py:206: def dispatch_tasks_to_user_port(): On 2015/06/23 09:40:27, Sebastian Noack wrote: > ...
June 23, 2015, 10:13 a.m. (2015-06-23 10:13:18 UTC) #6
mathias
Sorry, haven't seen the last comment before. https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode223 modules/rietveld/files/wrapper.py:223: return result ...
June 23, 2015, 10:32 a.m. (2015-06-23 10:32:42 UTC) #7
Wladimir Palant
LGTM
June 23, 2015, 10:49 a.m. (2015-06-23 10:49:41 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode220 modules/rietveld/files/wrapper.py:220: hostname, port = authority.split(":") if ":" in authority else ...
June 23, 2015, 11:34 a.m. (2015-06-23 11:34:05 UTC) #9
mathias
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode220 modules/rietveld/files/wrapper.py:220: hostname, port = authority.split(":") if ":" in authority else ...
June 23, 2015, 11:53 a.m. (2015-06-23 11:53:46 UTC) #10
Wladimir Palant
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode223 modules/rietveld/files/wrapper.py:223: return result > Anyway, this is yet another minor ...
June 23, 2015, 11:58 a.m. (2015-06-23 11:58:08 UTC) #11
Sebastian Noack
https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py File modules/rietveld/files/wrapper.py (right): https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode220 modules/rietveld/files/wrapper.py:220: hostname, port = authority.split(":") if ":" in authority else ...
June 23, 2015, noon (2015-06-23 12:00:24 UTC) #12
mathias
On 2015/06/23 12:00:24, Sebastian Noack wrote: > https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py > File modules/rietveld/files/wrapper.py (right): > > https://codereview.adblockplus.org/29321013/diff/29321016/modules/rietveld/files/wrapper.py#newcode220 ...
June 23, 2015, 12:03 p.m. (2015-06-23 12:03:17 UTC) #13
Sebastian Noack
On 2015/06/23 12:03:17, mathias wrote: > On 2015/06/23 12:00:24, Sebastian Noack wrote: > > Interesting, ...
June 23, 2015, 12:14 p.m. (2015-06-23 12:14:09 UTC) #14
Wladimir Palant
Can we agree on this patch being fine as is? The discussion only continues about ...
July 8, 2015, 10:06 p.m. (2015-07-08 22:06:01 UTC) #15
mathias
On 2015/07/08 22:06:01, Wladimir Palant wrote: > Can we agree on this patch being fine ...
July 8, 2015, 10:18 p.m. (2015-07-08 22:18:39 UTC) #16
Wladimir Palant
On 2015/07/08 22:18:39, mathias wrote: > I was actually waiting for Felix' LGTM anyway. Well, ...
July 8, 2015, 10:59 p.m. (2015-07-08 22:59:07 UTC) #17
Sebastian Noack
On 2015/07/08 22:06:01, Wladimir Palant wrote: > Can we agree on this patch being fine ...
July 9, 2015, 7:42 a.m. (2015-07-09 07:42:50 UTC) #18
mathias
July 9, 2015, 8:42 a.m. (2015-07-09 08:42:10 UTC) #19
Very well, I'll push this now.

Powered by Google App Engine
This is Rietveld