Issue 2376 - Implement custom filters in new options page

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 135 matching lines @@
     {
       this.text = text;
       this.disabled = false;
     }
   };
   modules.filterClasses.Filter.fromText = function(text)
   {
     return new modules.filterClasses.Filter(text);
   };
 
+  modules.filterValidation = 
+  {
+    parseFilter: function(text) 
+    {
+      var filterError = {filterError: false};
+      updateFromURL(filterError);

[Thomas Greiner, 2015/07/15 08:32:35]

Add this parameter to the README.

[saroyanm, 2015/07/15 10:47:08]

Done.

+      if (filterError)

[Sebastian Noack, 2015/07/15 09:00:44]

This will always be true. It should be |filterError.filterError|. Or to make it
less confusing, you might want to rename the variable to "params":

  var params = {filterError: false};
  updateFromURL(params);
  if (params.filterError)
    ...

[saroyanm, 2015/07/15 10:47:11]

Done.

+        return {error: "Filter-parsing-error-occurred"};

[Thomas Greiner, 2015/07/15 08:32:36]

I'd suggest to use all lower-case for consistency and to remove the "-occured"
at the end because it's an ID, not a statement.

[saroyanm, 2015/07/15 10:47:08]

Done.

+      return {filter: modules.filterClasses.Filter.fromText(text)};
+    },
+    parseFilters: function(text)
+    {
+      return {filters: text.split("\n").map(modules.filterClasses.Filter.fromText)};

[Thomas Greiner, 2015/07/15 08:32:35]

This line exceeds the 80 characters limit.

[Sebastian Noack, 2015/07/15 09:00:44]

You don't consider the filter filterError URL parameter here.

[saroyanm, 2015/07/15 10:47:09]

Done.

[saroyanm, 2015/07/15 10:47:11]

Done.

+    }
+  };
+
   modules.synchronizer = {
     Synchronizer: {}
   };
 
   modules.matcher = {
     defaultMatcher: {
       matchesAny: function(url, requestType, docDomain, thirdParty)
       {
         var params = {blockedURLs: ""};
         updateFromURL(params);
@@ skipping 48 matching lines @@
       {
         return parseFloat(v1) - parseFloat(v2);
       }
     }
   };
 
   var filters = [
     "@@||alternate.de^$document",
     "@@||der.postillion.com^$document", 
     "@@||taz.de^$document",
-    "@@||amazon.de^$document"
+    "@@||amazon.de^$document",
+    "||biglemon.am/bg_poster/banner.jpg",
+    "winfuture.de###header_logo_link",
+    "###WerbungObenRechts10_GesamtDIV",
+    "###WerbungObenRechts8_GesamtDIV",
+    "###WerbungObenRechts9_GesamtDIV",
+    "###WerbungUntenLinks4_GesamtDIV",
+    "###WerbungUntenLinks7_GesamtDIV",
+    "###WerbungUntenLinks8_GesamtDIV",
+    "###WerbungUntenLinks9_GesamtDIV",
+    "###Werbung_Sky",
+    "###Werbung_Wide",
+    "###__ligatus_placeholder__",
+    "###ad-bereich1-08",
+    "###ad-bereich1-superbanner",
+    "###ad-bereich2-08",
+    "###ad-bereich2-skyscrapper"
   ];
   var knownFilters = filters.map(modules.filterClasses.Filter.fromText);
 
   var subscriptions = [
     "https://easylist-downloads.adblockplus.org/easylistgermany+easylist.txt",
     "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
     "https://easylist-downloads.adblockplus.org/fanboy-social.txt",
     "~user~786254"
   ];
   var knownSubscriptions = Object.create(null);
@@ skipping 18 matching lines @@
         type: "message",
         payload: {
           title: "Custom subscription",
           url: "http://example.com/custom.txt",
           type: "add-subscription"
         }
       }, "*");
     }, 1000);
   }
 })(this);