Delta Between Two Patch Sets: README.md
Issue 29321198:
Issue 2376 - Implement custom filters in new options page (Closed)
Left Patch Set: Addressed initial comments
Created July 8, 2015, 6:13 p.m.
Right Patch Set: Nit fixes
Created July 15, 2015, 2:35 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
background.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| (no file at all) | |
| 1 Shared Adblock Plus UI code | 1 Shared Adblock Plus UI code |
| 2 =========================== | 2 =========================== |
| 3 | 3 |
| 4 The user interface elements defined in this repository will be used by various | 4 The user interface elements defined in this repository will be used by various |
| 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be | 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be |
| 6 tested within this repository, even though they might not work exactly the same | 6 tested within this repository, even though they might not work exactly the same |
| 7 as they will do in the final product. | 7 as they will do in the final product. |
| 8 | 8 |
| 9 Directory structure | 9 Directory structure |
| 10 ------------------- | 10 ------------------- |
| (...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 65 | 65 |
| 66 This is the implementation of the Adblock Plus options page which is the primary | 66 This is the implementation of the Adblock Plus options page which is the primary |
| 67 UI for changing settings and for managing filter lists. | 67 UI for changing settings and for managing filter lists. |
| 68 | 68 |
| 69 The behavior of this page is affected by a number of URL parameters: | 69 The behavior of this page is affected by a number of URL parameters: |
| 70 | 70 |
| 71 * `addonVersion`: sets addon version application parameter that is used for | 71 * `addonVersion`: sets addon version application parameter that is used for |
| 72 creating the link to the version-specific release notes | 72 creating the link to the version-specific release notes |
| 73 * `addSubscription=true`: this parameter should trigger a dialog for adding | 73 * `addSubscription=true`: this parameter should trigger a dialog for adding |
| 74 subscriptions as initiated by clicking on an "abp:subscribe" link | 74 subscriptions as initiated by clicking on an "abp:subscribe" link |
| 75 * `filterError=true`: causes filter validation to fail, showing validation | |
| 76 errors when adding new filters on the options page | |
| LEFT | RIGHT |
« no previous file
|
background.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
