Issue 2376 - Implement custom filters in new options page

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 417 matching lines @@
       delete document.body.dataset.dialog;
     }, false);
 
     // Advanced tab
     var filterTextbox = document.querySelector("#custom-filters-add input");
     placeholderValue = ext.i18n.getMessage("options_customFilters_textbox_placeholder");
     filterTextbox.setAttribute("placeholder", placeholderValue);
     function addCustomFilters()
     {
       var filterText = filterTextbox.value;
-      if (!filterText)
-        return;
-
       ext.backgroundPage.sendMessage(
       {
-        type: "filters.parse",
+        type: "filters.add",
         text: filterText
       });
       filterTextbox.value = "";
     }
     E("custom-filters-add").addEventListener("submit", function(e)
     {
       e.preventDefault();
       addCustomFilters();
     }, false);
     var customFilterEditButtons = document.querySelectorAll("#custom-filters-edit-wrapper button");
@@ skipping 247 matching lines @@
     switch (message.type)
     {
       case "app.listen":
         if (message.action == "addSubscription")
         {
           E("blockingList-textbox").value = message.args[0].url;
           openDialog("customlist");
         }
         else if (message.action == "error")
         {
-          var error = message.args[0];
-          //TODO handle error message

[Thomas Greiner, 2015/07/13 15:54:23]

We're not going to have a dedicated UI element for showing error messages so all
you need to do now is using `alert()` to output the error(s) like the current
options page does it:

alert(message.args);

+          alert(message.args.join("\n"));
         }
         break;
       case "filters.listen":
         onFilterMessage(message.action, message.args[0]);
         break;
       case "subscriptions.listen":
         onSubscriptionMessage(message.action, message.args[0]);
         break;
     }
   });
 
   ext.backgroundPage.sendMessage(
   {
     type: "app.listen",
-    filter: ["addSubscription"]

[Thomas Greiner, 2015/07/13 15:54:23]

The "error" action also needs to be added here to declare that it wants to
receive those messages.

[saroyanm, 2015/07/14 10:20:59]

I wander, shouldn't it only fire after it's registered here ?

[Thomas Greiner, 2015/07/14 10:58:52]

Exactly, that's why I asked you to make the change in messageResponder.js so
that the background page only dispatches messages to those endpoints which
registered a listener for a specific kind.

[saroyanm, 2015/07/14 11:19:25]

I think this question was remaining before We figured out what are filters
variable used for :)
Thanks for pointing wander why I had this comment here. 

+    filter: ["addSubscription", "error"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "filters.listen",
     filter: ["added", "loaded", "removed"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "removed", "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();