Issue 2376 - Implement custom filters in new options page

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 168 matching lines @@
         break;
       case "app.open":
         if (message.what == "options")
           ext.showOptions();
         break;
       case "filters.add":
         var filter = Filter.fromText(message.text);
         var result = filterValidation.parseFilter(message.text);
         if (result.error)
           sendMessage("app", "error", [result.error.toString()], sender.page);
-        else
+        else if (result.filter)
           FilterStorage.addFilter(result.filter);

[Sebastian Noack, 2015/07/14 16:48:40]

I pointed this out before: If |text.trim() == ""| then parseFilter() returns
{filter: null}, calling FilterStorage.addFilter(null) here, causing an error.
I've seen that you already bail out on the options page before sending the
filters.add message, if the filter text is an empty string. However if the text
is " " for example you still cause an unhandled error. I'd prefer to keep this
logic entirely to the parseFilter() function, simply handling result.filter
being null.

[saroyanm, 2015/07/14 18:28:29]

Done.

         break;
       case "filters.blocked":
         var filter = defaultMatcher.matchesAny(message.url, message.requestType,
           message.docDomain, message.thirdParty);
         callback(filter instanceof BlockingFilter);
         break;
       case "filters.get":
         var subscription = Subscription.fromURL(message.subscriptionUrl);
         if (!subscription)
         {
@@ skipping 116 matching lines @@
           subscription.title = message.title;
           subscription.homepage = message.homepage;
           FilterStorage.addSubscription(subscription);
           if (!subscription.lastDownload)
             Synchronizer.execute(subscription);
         }
         break;
     }
   });
 })(this);