README.md - Issue 29321198: Issue 2376 - Implement custom filters in new options page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29321198: Issue 2376 - Implement custom filters in new options page (Closed)

Left Patch Set: Added param to readme and some fixes Created July 15, 2015, 10:36 a.m.

Right Patch Set: Nit fixes Created July 15, 2015, 2:35 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Shared Adblock Plus UI code	1 Shared Adblock Plus UI code

2 ===========================	2 ===========================

3	3

4 The user interface elements defined in this repository will be used by various	4 The user interface elements defined in this repository will be used by various

5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be	5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be

6 tested within this repository, even though they might not work exactly the same	6 tested within this repository, even though they might not work exactly the same

7 as they will do in the final product.	7 as they will do in the final product.

8	8

9 Directory structure	9 Directory structure

10 -------------------	10 -------------------

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65	65

66 This is the implementation of the Adblock Plus options page which is the primary	66 This is the implementation of the Adblock Plus options page which is the primary

67 UI for changing settings and for managing filter lists.	67 UI for changing settings and for managing filter lists.

68	68

69 The behavior of this page is affected by a number of URL parameters:	69 The behavior of this page is affected by a number of URL parameters:

70	70

71 * `addonVersion`: sets addon version application parameter that is used for	71 * `addonVersion`: sets addon version application parameter that is used for

72 creating the link to the version-specific release notes	72 creating the link to the version-specific release notes

73 * `addSubscription=true`: this parameter should trigger a dialog for adding	73 * `addSubscription=true`: this parameter should trigger a dialog for adding

74 subscriptions as initiated by clicking on an "abp:subscribe" link	74 subscriptions as initiated by clicking on an "abp:subscribe" link

75 * `filterError=true`: this parameter should trigger filter parsing error	75 * `filterError=true`: causes filter validation to fail, showing validation
Sebastian Noack 2015/07/15 11:19:59 IMO better: "causes filter validation to fail, sho IMO better: "causes filter validation to fail, showing validation errors when adding new filters on the options page" saroyanm 2015/07/15 12:06:52 Done. Show quoted text On 2015/07/15 11:19:59, Sebastian Noack wrote: > IMO better: "causes filter validation to fail, showing validation errors when > adding new filters on the options page" Done.
76 after atempt of adding new filter	76 errors when adding new filters on the options page

LEFT	RIGHT